[GitHub] [pinot] KKcorps commented on a diff in pull request #10364: Add operator level stats to response when tracing is enabled

["KKcorps (via GitHub)" <gi...@apache.org>]

KKcorps commented on code in PR #10364:
URL: https://github.com/apache/pinot/pull/10364#discussion_r1124099328


##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ExecutionStatsAggregator.java:
##########
@@ -117,6 +118,13 @@ public synchronized void aggregate(@Nullable ServerRoutingInstance routingInstan
     String operatorId = metadata.get(DataTable.MetadataKey.OPERATOR_ID.getName());
     if (operatorId != null) {
       _operatorIds.add(operatorId);
+      if (_enableTrace) {
+        Map<String, String> metadataWithoutOperatorId = new HashMap<>(metadata);
+        metadataWithoutOperatorId.remove(DataTable.MetadataKey.OPERATOR_ID);

Review Comment:
   Only reason is because the response looks unclean. The key is already operatorID and inside the map we put operatorId again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org