You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2013/07/11 02:52:15 UTC

mac commit: [CB-3179] Change to in config.xml and remove deprecation notice in OSX

Updated Branches:
  refs/heads/master 5c6916fe1 -> a166d3f61


[CB-3179] Change <plugin> to <feature> in config.xml and remove deprecation notice in OSX


Project: http://git-wip-us.apache.org/repos/asf/cordova-osx/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-osx/commit/a166d3f6
Tree: http://git-wip-us.apache.org/repos/asf/cordova-osx/tree/a166d3f6
Diff: http://git-wip-us.apache.org/repos/asf/cordova-osx/diff/a166d3f6

Branch: refs/heads/master
Commit: a166d3f618c80a29217ab417d5d3a842208b873e
Parents: 5c6916f
Author: Shazron Abdullah <sh...@apache.org>
Authored: Wed Jul 10 17:52:07 2013 -0700
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Wed Jul 10 17:52:07 2013 -0700

----------------------------------------------------------------------
 .../Classes/Commands/CDVConfigParser.m                 | 13 -------------
 bin/templates/project/__TESTING__/config.xml           |  3 ---
 2 files changed, 16 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-osx/blob/a166d3f6/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m
----------------------------------------------------------------------
diff --git a/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m b/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m
index b33a6ca..3cabb8c 100644
--- a/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m
+++ b/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m
@@ -71,19 +71,6 @@
 {
     if ([elementName isEqualToString:@"preference"]) {
         settings[attributeDict[@"name"]] = attributeDict[@"value"];
-    } else if ([elementName isEqualToString:@"plugin"]) {
-        NSString* name = [attributeDict[@"name"] lowercaseString];
-        pluginsDict[name] = attributeDict[@"value"];
-        if ([@"true" isEqualToString : attributeDict[@"onload"]]) {
-            [self.startupPluginNames addObject:name];
-        }
-        NSLog(@"\nUse of the <plugin> tag has been deprecated. Use a <feature> tag instead. Change:\n"
-            @"    <plugin name=\"%@\" value=\"%@\" />\n"
-            @"To:\n"
-            @"    <feature name=\"%@\">\n"
-            @"        <param name=\"ios-package\" value=\"%@\" />\n"
-            @"    </feature>\n"
-            , attributeDict[@"name"], attributeDict[@"value"], attributeDict[@"name"], attributeDict[@"value"]);
     } else if ([elementName isEqualToString:@"feature"]) { // store feature name to use with correct parameter set
         featureName = [attributeDict[@"name"] lowercaseString];
     } else if ((featureName != nil) && [elementName isEqualToString:@"param"]) {

http://git-wip-us.apache.org/repos/asf/cordova-osx/blob/a166d3f6/bin/templates/project/__TESTING__/config.xml
----------------------------------------------------------------------
diff --git a/bin/templates/project/__TESTING__/config.xml b/bin/templates/project/__TESTING__/config.xml
index 57a0d63..bb89a5d 100644
--- a/bin/templates/project/__TESTING__/config.xml
+++ b/bin/templates/project/__TESTING__/config.xml
@@ -46,7 +46,4 @@
     <feature name="NetworkStatus">
       <param name="ios-package" value="CDVConnection"/>
     </feature>
-    <!-- Deprecated plugins element. REmove in 3.0 -->
-    <plugins>
-    </plugins>
 </widget>