[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16866: Remove default_args pattern + added get_current_context() use for Core Airflow example DAGs

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #16866:
URL: https://github.com/apache/airflow/pull/16866#discussion_r686660646



##########
File path: airflow/example_dags/example_xcom.py
##########
@@ -78,6 +104,14 @@ def puller(**kwargs):
     pull = PythonOperator(
         task_id='puller',
         python_callable=puller,
+        op_kwargs={
+            'pulled_value_1': push1.output['value from pusher 1'],
+            'pulled_value_3': push2.output,
+        },

Review comment:
       I think that we shouldn't use PythonOperator at all for this example if we want to use the TaskFlow API because TaskFlowAPI is an abstraction of the PythonOperator. Using both the TaskFlow API and PythonOperator in the same example doesn't look great to me.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org