[jira] [Commented] (DRILL-4089) Make JSON pretty printing configurable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007088#comment-15007088 ] 

ASF GitHub Bot commented on DRILL-4089:
---------------------------------------

GitHub user hnfgns opened a pull request:

    https://github.com/apache/drill/pull/259

    DRILL-4089: make JSON pretty printing configurable

    Use system dependent line-feed to seperate records when pretty printing is turned off
    Refactor ExecConstants to eliminate unneeded modifier & accessor declarations

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hnfgns/incubator-drill DRILL-4089

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #259
    
----
commit 0b118c9b34a3bcf4a11a40b5c7777c25862126bd
Author: Hanifi Gunes <ha...@gmail.com>
Date:   2015-11-13T23:51:31Z

    DRILL-4089: make JSON pretty printing configurable
    Use system dependent line-feed to seperate records when pretty printing is turned off
    refactor ExecConstants to eliminate unneeded modifier & accessor declarations

----


> Make JSON pretty printing configurable
> --------------------------------------
>
>                 Key: DRILL-4089
>                 URL: https://issues.apache.org/jira/browse/DRILL-4089
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>            Reporter: Hanifi Gunes
>            Assignee: Hanifi Gunes
>
> Currently JSON record writer emits records pretty-printed and there is no way to configure this behavior. This issue proposes to make this configurable via a prettyPrint switch in -storage- execution configuration with default value of true to ensure backward compatibility.
> As a guideline, the following should be used to dictate Drill to emit records in JSON.
> {code:sql}
> alter [session|sytem] set `store.format`='json';
> {code}
> and this new switch should be used to turn off pretty printing:
> {code:sql}
> alter [session|sytem] set `store.json.writer.uglify`='true';
> {code}
> By default, Drill will use system dependent line feed to seperate JSON blobs when pretty printing turned off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)