You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2004/03/10 17:23:05 UTC
Re: svn commit: r8962 - trunk/subversion/libsvn_wc
cmpilato@tigris.org wrote:
> Author: cmpilato
> Date: Wed Mar 10 10:55:21 2004
> New Revision: 8962
>
> Modified:
> trunk/subversion/libsvn_wc/status.c
> Log:
> Follow-up to r8842. I forgot that eb->target is never NULL (but that
> *eb->target) might be.
Is it important to get that into 1.0.1, since r8842 has already been merged into the 1.0.1 branch? Do you know what the consequences of this bug are? You probably ought to nominate it first and answer questions later :-)
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r8962 - trunk/subversion/libsvn_wc
Posted by makl <ma...@tigris.org>.
Julian Foad wrote:
> In what way? Do you mean that the regression tests pass, or that you
> have done a test that fails without the patch and passes with it?
I accomplished some tests with status and externals and received the
expected results.
If I did not miss some corner cases and my expectations are correct (who
knows) then the patch is correct.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r8962 - trunk/subversion/libsvn_wc
Posted by Julian Foad <ju...@btopenworld.com>.
makl wrote:
> The patch seems to work.
In what way? Do you mean that the regression tests pass, or that you have done a test that fails without the patch and passes with it?
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r8962 - trunk/subversion/libsvn_wc
Posted by makl <ma...@tigris.org>.
The patch seems to work.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r8962 - trunk/subversion/libsvn_wc
Posted by "C. Michael Pilato" <cm...@collab.net>.
Julian Foad <ju...@btopenworld.com> writes:
> cmpilato@tigris.org wrote:
> > Author: cmpilato
> > Date: Wed Mar 10 10:55:21 2004
> > New Revision: 8962
> > Modified:
> > trunk/subversion/libsvn_wc/status.c
> > Log:
> > Follow-up to r8842. I forgot that eb->target is never NULL (but that
> > *eb->target) might be.
>
> Is it important to get that into 1.0.1, since r8842 has already been
> merged into the 1.0.1 branch? Do you know what the consequences of
> this bug are? You probably ought to nominate it first and answer
> questions later :-)
sussman is supposed to be nominating it now. The consequences are
that 'svn st' might not descend into externals in particular cases.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r8962 - trunk/subversion/libsvn_wc
Posted by Ben Collins-Sussman <su...@collab.net>.
On Wed, 2004-03-10 at 11:23, Julian Foad wrote:
> cmpilato@tigris.org wrote:
> > Author: cmpilato
> > Date: Wed Mar 10 10:55:21 2004
> > New Revision: 8962
> >
> > Modified:
> > trunk/subversion/libsvn_wc/status.c
> > Log:
> > Follow-up to r8842. I forgot that eb->target is never NULL (but that
> > *eb->target) might be.
>
> Is it important to get that into 1.0.1, since r8842 has already been merged into the 1.0.1 branch? Do you know what the consequences of this bug are? You probably ought to nominate it first and answer questions later :-)
Nominating now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org