You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2020/12/07 13:08:49 UTC

[GitHub] [brooklyn-server] jcabrerizo opened a new pull request #1132: Added config key

jcabrerizo opened a new pull request #1132:
URL: https://github.com/apache/brooklyn-server/pull/1132


   Added new config key `PERSISTENCE_DIR_MUST_EXIST` for make the start up fail when the persistand forlder doesn't exist. 
   The default value is false so it doesn't change the default behaviour.
   
   For enable it update the `brooklyn.cfg` file to contain
   ```
   brooklyn.persistence.dir.required = true
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] asfgit closed pull request #1132: Added config key

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1132:
URL: https://github.com/apache/brooklyn-server/pull/1132


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] ahgittin commented on pull request #1132: Added config key

Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #1132:
URL: https://github.com/apache/brooklyn-server/pull/1132#issuecomment-740230207


   unrelated test failure, apparently non-deterministic.  i can't replicate it, even with delays, and doesn't seem to make sense in the code because it always does stopping (where the NPE happens) before stopped (which sets the var to null).
   
   for reference the error was:
   
   ```
   java.lang.reflect.UndeclaredThrowableException
   	at com.sun.proxy.$Proxy588.removeMember(Unknown Source)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager.unmanageNonRecursive(LocalEntityManager.java:813)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager.unmanage(LocalEntityManager.java:560)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager.unmanage(LocalEntityManager.java:463)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager.unmanage(LocalEntityManager.java:458)
   	at org.apache.brooklyn.core.entity.Entities.unmanage(Entities.java:977)
   	at org.apache.brooklyn.core.location.dynamic.clocker.StubHostLocation.release(StubHostLocation.java:175)
   	at org.apache.brooklyn.core.location.dynamic.clocker.StubInfrastructureLocation.release(StubInfrastructureLocation.java:144)
   	at org.apache.brooklyn.core.location.dynamic.clocker.ClockerDynamicLocationPatternRebindTest.testRebind(ClockerDynamicLocationPatternRebindTest.java:132)
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.lang.reflect.Method.invoke(Method.java:498)
   	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
   	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
   	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
   	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
   	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
   	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
   	at org.testng.TestRunner.privateRun(TestRunner.java:756)
   	at org.testng.TestRunner.run(TestRunner.java:610)
   	at org.testng.SuiteRunner.runTest(SuiteRunner.java:387)
   	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:382)
   	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340)
   	at org.testng.SuiteRunner.run(SuiteRunner.java:289)
   	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1293)
   	at org.testng.TestNG.runSuitesLocally(TestNG.java:1218)
   	at org.testng.TestNG.runSuites(TestNG.java:1133)
   	at org.testng.TestNG.run(TestNG.java:1104)
   	at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:132)
   	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:193)
   	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:94)
   	at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:147)
   	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
   	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
   	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
   Caused by: java.lang.reflect.InvocationTargetException
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.lang.reflect.Method.invoke(Method.java:498)
   	at org.apache.brooklyn.core.objs.proxy.EntityProxyImpl.invoke(EntityProxyImpl.java:214)
   	... 38 more
   Caused by: java.lang.NullPointerException
   	at org.apache.brooklyn.core.mgmt.internal.EntityManagementSupport.onManagementStopping(EntityManagementSupport.java:325)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager$3.apply(LocalEntityManager.java:554)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager$3.apply(LocalEntityManager.java:551)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager.recursively(LocalEntityManager.java:688)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager.unmanage(LocalEntityManager.java:551)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager.unmanage(LocalEntityManager.java:463)
   	at org.apache.brooklyn.core.mgmt.internal.LocalEntityManager.unmanage(LocalEntityManager.java:458)
   	at org.apache.brooklyn.core.entity.Entities.unmanage(Entities.java:977)
   	at org.apache.brooklyn.entity.group.AbstractGroupImpl.lambda$removeMember$2(AbstractGroupImpl.java:186)
   	at org.apache.brooklyn.util.concurrent.Locks.withLock(Locks.java:35)
   	at org.apache.brooklyn.entity.group.AbstractGroupImpl.removeMember(AbstractGroupImpl.java:159)
   	... 43 more
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] ahgittin commented on pull request #1132: Added config key

Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #1132:
URL: https://github.com/apache/brooklyn-server/pull/1132#issuecomment-740230256


   code here itself looks great, so merging


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [brooklyn-server] asfgit merged pull request #1132: Added config key

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1132:
URL: https://github.com/apache/brooklyn-server/pull/1132


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org