You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/24 12:56:45 UTC
[GitHub] [arrow] thisisnic opened a new pull request #10383: ARROW-12777: [R] Convert all inputs to Arrow objects in match_arrow and is_in
thisisnic opened a new pull request #10383:
URL: https://github.com/apache/arrow/pull/10383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #10383: ARROW-12777: [R] Convert all inputs to Arrow objects in match_arrow and is_in
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #10383:
URL: https://github.com/apache/arrow/pull/10383#discussion_r640955015
##########
File path: r/R/compute.R
##########
@@ -241,13 +241,11 @@ all.ArrowDatum <- function(..., na.rm = FALSE){
#' `boolean`-type `Array` of the same length as `x` with values indicating
#' per element of `x` it it is present in `table`.
#' @export
-match_arrow <- function(x, table, ...) UseMethod("match_arrow")
-
-#' @export
-match_arrow.default <- function(x, table, ...) match(x, table, ...)
Review comment:
@jonkeane That makes sense, it is a breaking change after all. Just committed an update - let me know if I should rephrase it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10383: ARROW-12777: [R] Convert all inputs to Arrow objects in match_arrow and is_in
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10383:
URL: https://github.com/apache/arrow/pull/10383#discussion_r640931089
##########
File path: r/R/compute.R
##########
@@ -241,13 +241,11 @@ all.ArrowDatum <- function(..., na.rm = FALSE){
#' `boolean`-type `Array` of the same length as `x` with values indicating
#' per element of `x` it it is present in `table`.
#' @export
-match_arrow <- function(x, table, ...) UseMethod("match_arrow")
-
-#' @export
-match_arrow.default <- function(x, table, ...) match(x, table, ...)
Review comment:
This is probably over-board, but we are changing the behavior here, might we want a warning here (maybe temporary? maybe only once per session) in the case where both `x` and `table` are not Arrow objects and mention that this behavior is different?
Maybe an entry in news describing this would be sufficient. The use of `match_arrow()` to dispatch `base::match()` is certainly an off-label use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10383: ARROW-12777: [R] Convert all inputs to Arrow objects in match_arrow and is_in
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10383:
URL: https://github.com/apache/arrow/pull/10383#issuecomment-847023803
https://issues.apache.org/jira/browse/ARROW-12777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10383: ARROW-12777: [R] Convert all inputs to Arrow objects in match_arrow and is_in
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10383:
URL: https://github.com/apache/arrow/pull/10383#discussion_r640956886
##########
File path: r/R/compute.R
##########
@@ -241,13 +241,11 @@ all.ArrowDatum <- function(..., na.rm = FALSE){
#' `boolean`-type `Array` of the same length as `x` with values indicating
#' per element of `x` it it is present in `table`.
#' @export
-match_arrow <- function(x, table, ...) UseMethod("match_arrow")
-
-#' @export
-match_arrow.default <- function(x, table, ...) match(x, table, ...)
Review comment:
That looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #10383: ARROW-12777: [R] Convert all inputs to Arrow objects in match_arrow and is_in
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #10383:
URL: https://github.com/apache/arrow/pull/10383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org