You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/10 09:19:43 UTC

[GitHub] [pulsar] lhotari commented on pull request #17022: [improve][test] force initialize field to avoid polluted by mocks

lhotari commented on PR #17022:
URL: https://github.com/apache/pulsar/pull/17022#issuecomment-1210397973

   @tisonkun Have you checked with a debugger or logging that the tests actually do what they are claiming to do? (for example recover after OOME)
   
   I'm not a great fan of these tests and I'm fine with removing them. However my concern is that after the changes, they won't be really testing anything and no OOME is thrown ever. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org