You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/26 09:09:07 UTC

[GitHub] [airflow] penggongkui opened a new issue #13911: TaskGroup need the default_args like dag

penggongkui opened a new issue #13911:
URL: https://github.com/apache/airflow/issues/13911


   I wan't to use taskgroup to replace subdag, but i find it cannot add default_args, so i have to add a **default_args to my tasks.
   
   how about add a feature, taskgroup has a default_args param, and it will pass to it's children task
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] xinbinhuang commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-792042689


   I will work on this @eladkal 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-866765791


   This will likely be released in 2.2. 2.1 has already split out of main, and 2.1.1 will be released from that branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr edited a comment on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-866766056


   Also, since the PR has been merged, should this issue be closed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] penggongkui commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
penggongkui commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-864913596


   @xinbinhuang @jhtimmins I have fnished the feature, Could you please review the code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] penggongkui commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
penggongkui commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-767818065


   I want in the same dag , different taskgroup has different default_args,
   subdag can do it but task group can't
   
   On Tue, Jan 26, 2021, 23:29 Tomek Urbaszek <no...@github.com> wrote:
   
   > You can pass default_args in DAG that will include TaskGroup. TaskGroup
   > needs to live within a DAG, it does not substitute it as far as I
   > understand.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/issues/13911#issuecomment-767620957>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ALW4V6YUBBOPAJ2PPCBNYS3S33NWBANCNFSM4WTDKSHA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-866135503


   The milestone will be set by the release manager when the PR is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jhtimmins commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
jhtimmins commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-833226869


   @xinbinhuang Were you able to work on this one? If we can get it merged this week it can be included in the 2.1 release, otherwise we'll target a later release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] xinbinhuang commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-833710073


   @jhtimmins  hey sorry, this skips through my head. Let me work on this tonight! Will pin you for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-767620957


   You can pass `default_args` in DAG that will include TaskGroup. TaskGroup needs to live within a DAG, it does not substitute it as far as I understand. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] penggongkui commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
penggongkui commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-866109434


   @eladkal Would you mind move this issue to milestone 2.1.1(it seams the version is going to release). I have waited for this feature for a really long time(about a half of year) 😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] penggongkui commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
penggongkui commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-864913596


   @xinbinhuang @jhtimmins I have fnished the feature, Could you please review the code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-866766056


   Also, since the PR has been merged, should this issue be closed/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] penggongkui closed issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
penggongkui closed issue #13911:
URL: https://github.com/apache/airflow/issues/13911


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] penggongkui commented on issue #13911: TaskGroup need the default_args like dag

Posted by GitBox <gi...@apache.org>.
penggongkui commented on issue #13911:
URL: https://github.com/apache/airflow/issues/13911#issuecomment-844939817


   @xinbinhuang any update on this feature? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org