You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2016/12/22 06:03:51 UTC

[2/4] mesos git commit: Removed the use of `FORTIFY_SOURCE` from stout.

Removed the use of `FORTIFY_SOURCE` from stout.

`FORTIFY_SOURCE` is no longer used when hardening. This is to prevent
the warning that some versions of gcc/libc throw when `FORTIFY_SOURCE`
is used without optimizations. The warning turns into an error via
`-Werror` and fails the whole build.

Review: https://reviews.apache.org/r/54951/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/0f01d716
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/0f01d716
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/0f01d716

Branch: refs/heads/master
Commit: 0f01d716072090a6fabf1529927b00d40db25eec
Parents: 70e02e7
Author: Aaron Wood <aa...@verizon.com>
Authored: Wed Dec 21 18:47:43 2016 -0500
Committer: Michael Park <mp...@apache.org>
Committed: Thu Dec 22 01:02:23 2016 -0500

----------------------------------------------------------------------
 3rdparty/stout/Makefile.am | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/0f01d716/3rdparty/stout/Makefile.am
----------------------------------------------------------------------
diff --git a/3rdparty/stout/Makefile.am b/3rdparty/stout/Makefile.am
index 2d27da7..ebf1069 100644
--- a/3rdparty/stout/Makefile.am
+++ b/3rdparty/stout/Makefile.am
@@ -24,8 +24,6 @@ if ENABLE_HARDENING
 # Protect many of the functions with stack guards
 # (either -fstack-protector-strong or -fstack-protector depending on compiler support).
 AM_CXXFLAGS += @STACK_PROTECTOR@
-# Better protect against potential buffer overflow attacks.
-AM_CXXFLAGS += -D_FORTIFY_SOURCE=2
 # Produce position independent code when appropriate.
 AM_CXXFLAGS += -fPIC -fPIE
 endif