You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "aditya-gupta36 (via GitHub)" <gi...@apache.org> on 2025/10/31 07:12:04 UTC
[PR] ATLAS-5056: Entity audit should not be created for instances of internal entity-types [atlas]
aditya-gupta36 opened a new pull request, #471:
URL: https://github.com/apache/atlas/pull/471
## What changes were proposed in this pull request?
Before fix:
skipAuditEntries(): false → audit processing proceeds
EntityAuditListenerV2.onEntitiesAdded appears → audit entries created
After fix:
skipAuditEntries(): true (allInternal=true) → early exit
No notifyV2Listeners log → processing skipped
No EntityAuditListenerV2.onEntitiesAdded log → no audit entries created
## How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5056: Entity audit should not be created for instances of internal entity-types [atlas]
Posted by "pinal-shah (via GitHub)" <gi...@apache.org>.
pinal-shah merged PR #471:
URL: https://github.com/apache/atlas/pull/471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5056: Entity audit should not be created for instances of internal entity-types [atlas]
Posted by "chaitalicod (via GitHub)" <gi...@apache.org>.
chaitalicod commented on code in PR #471:
URL: https://github.com/apache/atlas/pull/471#discussion_r2633741618
##########
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java:
##########
@@ -401,7 +399,26 @@ private String getListenerName(EntityChangeListener listener) {
}
private boolean skipAuditEntries(List<AtlasEntityHeader> entityHeaders) {
- return CollectionUtils.isEmpty(entityHeaders) || entityHeaders.stream().noneMatch(PRED_IS_NOT_TYPE_AUDIT_ENTITY);
+ if (CollectionUtils.isEmpty(entityHeaders)) {
+ return true;
+ }
+
+ // Skip audit if ALL entities are internal types (__AtlasAuditEntry, __AtlasMetricsStat, etc.)
Review Comment:
check if you can make your comments more precise and short?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org