You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2015/09/04 14:51:54 UTC
[GitHub] incubator-zeppelin pull request: Fix zeppelin-server security test...
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/281
Fix zeppelin-server security tests on case-sensitive hostname
On os x, w/ case-sensitive hostname some test for zeppelin-server were failing
```
$hostname
MacBookPro.local
$mvn -pl zeppelin-server test
...
Results :
Failed tests:
SecurityUtilsTest.isLocalMachine:56 null
NotebookServerTest.CheckOrigin:43 null
Tests run: 22, Failures: 2, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
```
This PR changes fixes it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator-zeppelin fix-security-tests-on-casesensitive-hostnames
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/281.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #281
----
commit b26639df91c9bbb15838ddf13be6ba4722a0c088
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-09-04T10:21:22Z
Refactoring SecurityUtils and its test
commit 64c3573fd5e5f8d8e62ab88624b33f538aabae61
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-09-04T10:55:29Z
Refactoring NotebookServerTest
commit a72945b1e07ed14a58a5054cf84a5ffb5837c382
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-09-04T10:57:08Z
Fixing bug with case-sensitive hostnames
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix zeppelin-server security test...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/281#issuecomment-137759817
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix zeppelin-server security test...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/281
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---