You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "spmallette (via GitHub)" <gi...@apache.org> on 2023/02/03 11:25:55 UTC

[GitHub] [tinkerpop] spmallette commented on pull request #1961: TINKERPOP-2864 GraphBinaryMessageSerializer supports DefaultComputerResult

spmallette commented on PR #1961:
URL: https://github.com/apache/tinkerpop/pull/1961#issuecomment-1415739057

   GraphBinary is meant to return types that can be returned by the Gremlin language, not any random script. Random scripts should convert their results to one of the primitive types GraphBinary exposes. So your `toString()` of `ComputerResult` is at least one approach you could take there. It's tempting but I don't think we should get in the business of doing a quiet `toString()` by default. I feel like the user should know if a serializer isn't present directly by exception, then they alter their request accordingly. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org