You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "Martin Eigenbrodt (JIRA)" <ji...@apache.org> on 2009/03/02 10:50:12 UTC
[jira] Created: (IVY-1037) Buildnumber task does not work for
chained resolvers
Buildnumber task does not work for chained resolvers
----------------------------------------------------
Key: IVY-1037
URL: https://issues.apache.org/jira/browse/IVY-1037
Project: Ivy
Issue Type: Bug
Components: Ant
Reporter: Martin Eigenbrodt
Fix For: trunk
If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
I will attach a unittest to show the problem.
I've debuged into this point:
The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Martin Eigenbrodt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678612#action_12678612 ]
Martin Eigenbrodt commented on IVY-1037:
----------------------------------------
I would expect the buildnumbertask on a chained resovler to take in acount
all revisions.
Example:
ChainResolver
Resolver 1:
module "A" in Revision 4
Resolver 2
module "A" n Revision 2
<buildnumber resolver="ChainResolver"> should give "5" as next number.
I'm very into the ivy code but i Think there must be a way to ask a chained
resolver for all artifacts. Somethingh Like ListTokenValue but including
child.
2009/3/3 Maarten Coene (JIRA) <ji...@apache.org>
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant
> Reporter: Martin Eigenbrodt
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene updated IVY-1037:
-------------------------------
Fix Version/s: (was: trunk)
2.0.1
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant, Core
> Reporter: Martin Eigenbrodt
> Assignee: Maarten Coene
> Fix For: 2.0.1
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Martin Eigenbrodt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678656#action_12678656 ]
Martin Eigenbrodt commented on IVY-1037:
----------------------------------------
A Workaround that is not to hard to implement is to allow the resovler
attribute to contain a Comma or space seperated list of
multiple resolvers. Users could than specify the individual resolvers.
However I'd prefere a "real" solution.
2009/3/4 Xavier Hanin (JIRA) <ji...@apache.org>
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant
> Reporter: Martin Eigenbrodt
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Martin Eigenbrodt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677942#action_12677942 ]
Martin Eigenbrodt commented on IVY-1037:
----------------------------------------
The Diff was made against the test Dir of the current trunkt.
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant
> Reporter: Martin Eigenbrodt
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Martin Eigenbrodt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Eigenbrodt closed IVY-1037.
----------------------------------
Resolution: Fixed
Thanks Maarten. Your commit solved the unittest and my "real world problem". Have you considered commiting the test? Is there anythingh I could/should have done better there?
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant
> Reporter: Martin Eigenbrodt
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene updated IVY-1037:
-------------------------------
Component/s: Core
Assignee: Maarten Coene
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant, Core
> Reporter: Martin Eigenbrodt
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Martin Eigenbrodt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Eigenbrodt updated IVY-1037:
-----------------------------------
Attachment: IVY1037.patch
A Unittest to reproduce the bug.
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant
> Reporter: Martin Eigenbrodt
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678938#action_12678938 ]
Maarten Coene commented on IVY-1037:
------------------------------------
I've implemented the listTokenValues method of the ChainResolver and added it into SVN trunk.
Could you give it a try to see if it solves your problem?
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant
> Reporter: Martin Eigenbrodt
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679386#action_12679386 ]
Maarten Coene commented on IVY-1037:
------------------------------------
I've committed the junit test as well.
Thanks again for the contribution.
Maarten
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant, Core
> Reporter: Martin Eigenbrodt
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678618#action_12678618 ]
Xavier Hanin commented on IVY-1037:
-----------------------------------
>From the functional point of view, I agree with Martin, taking into account all resolvers is what seems the most natural.
Now I'm not sure how difficult it is to implement, if we don't do it, we should at least document this limitation clearly.
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant
> Reporter: Martin Eigenbrodt
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679128#action_12679128 ]
Maarten Coene commented on IVY-1037:
------------------------------------
Martin, I didn't commit the junit test yet, I wanted to know if your problem was solved before committing it. Now that I know it solved your problem, I can commit the junit test. The only thing I changed was that I merged your test-class into the already existing IvyBuildnumberTest.
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant, Core
> Reporter: Martin Eigenbrodt
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1037) Buildnumber task does not work for
chained resolvers
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678452#action_12678452 ]
Maarten Coene commented on IVY-1037:
------------------------------------
I'm not sure what would be the correct behaviour for the ChainResolver to do in this situation...
Anyone has some good ideas?
> Buildnumber task does not work for chained resolvers
> ----------------------------------------------------
>
> Key: IVY-1037
> URL: https://issues.apache.org/jira/browse/IVY-1037
> Project: Ivy
> Issue Type: Bug
> Components: Ant
> Reporter: Martin Eigenbrodt
> Fix For: trunk
>
> Attachments: IVY1037.patch
>
>
> If the resolver attribute of the buildnumber task point to a chained resolver the buildnumber task will not find any existing revision.
> I will attach a unittest to show the problem.
> I've debuged into this point:
> The Buildnubmer task uses SearchEngine.listModules whcih in turn uses
> Resolver.listTokenValues. The Doc says ListTokenValue must not return values for child resolvers.
> So litTokenValues can not return values for child resolvers either. I don't know how to fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.