[jira] Resolved: (IVY-737) [PATCH] XML entity parsing fix

["Xavier Hanin (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IVY-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xavier Hanin resolved IVY-737.
------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.0)
                   2.0-RC1

I've applied your patches, thanks a lot for your contribution, and welcome to the list of contributors!

> [PATCH] XML entity parsing fix
> ------------------------------
>
>                 Key: IVY-737
>                 URL: https://issues.apache.org/jira/browse/IVY-737
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Patrick Woodworth
>            Assignee: Xavier Hanin
>             Fix For: 2.0-RC1
>
>         Attachments: ivy-entities-fix-r2.patch, xml-entities-test.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Ivy's parsing of XML files does not properly resolve XML SYSTEM entities.  The problem appears systemic and widespread, with the underlying cause being the general pattern of always converting to-be-parsed resources (i.e. URL(s), File(s), etc.) to InputStream(s) before handing them off to the SAXParser#parse(...) method.  This pattern strips all contextual information about the source and prevents the parser from properly resolving relative paths to entity sources.
> While I believe the problem is widespread and beyond the scope of a first time submitter, I have managed to create a minimal patch that fixes the issue where it would most often affect users.  Specifically this patch fixes entity resolution for the parsing of settings.xml and ivy.xml files that would be found in a source tree as opposed to ivy.xml files that would be found in repositories.  Another way of looking at it is that my patch fixes entity parsing for any file that would be parsed by the <ivy:buildlist/> task.
> I have also provided a second patch which provides a test-case for this issue, however for a quick example of what I'm talking about, one can simply look here: http://ant.apache.org/faq.html#xml-entity-include

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.