You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Pei He (JIRA)" <ji...@apache.org> on 2017/01/24 22:45:26 UTC
[jira] [Updated] (BEAM-1306) Support additional configuration in BigQueryServices.insertAll()

     [ https://issues.apache.org/jira/browse/BEAM-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pei He updated BEAM-1306:
-------------------------
    Description: 
ignoreUnknownValues is requested in https://issues.apache.org/jira/browse/BEAM-1267

There are additional configurations that could be useful.
TableDataInsertAllRequest content = new TableDataInsertAllRequest();
content.setSkipInvalidRows();
content.setTemplateSuffix();
content.setKind();
            
I think we can improve the BigQueryServices interface by define it as:
void insertAll(TableReference ref, Collection<TableDataInsertAllRequest> request);
and, provided a static method to prepare requests:

List<TableDataInsertAllRequest> makeInsertBatches(List<TableRow> rowList, @Nullable List<String> insertIdList);
Then, client can set additional config in the returned list.

Reference:
GcsUtil.java has similar implementation in makeCopyBatches() and executeBatches().
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java#L550

  was:
ignoreUnknownValues is requested in https://issues.apache.org/jira/browse/BEAM-1267

There are additional configurations that could be useful.
TableDataInsertAllRequest content = new TableDataInsertAllRequest();
content.setSkipInvalidRows();
content.setTemplateSuffix();
content.setKind();
            
I think we can improve the BigQueryServices interface by define it as:
void insertAll(TableReference ref, Collection<TableDataInsertAllRequest> request);
and, provided a static method to prepare requests:

List<TableDataInsertAllRequest> makeInsertBatches(List<TableRow> rowList, @Nullable List<String> insertIdList);
Then, client can set additional config in the returned list.


GcsUtil.java has similar implementation in makeCopyBatches() and executeBatches().
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java#L550


> Support additional configuration in BigQueryServices.insertAll()
> ----------------------------------------------------------------
>
>                 Key: BEAM-1306
>                 URL: https://issues.apache.org/jira/browse/BEAM-1306
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>            Reporter: Pei He
>            Assignee: Pei He
>
> ignoreUnknownValues is requested in https://issues.apache.org/jira/browse/BEAM-1267
> There are additional configurations that could be useful.
> TableDataInsertAllRequest content = new TableDataInsertAllRequest();
> content.setSkipInvalidRows();
> content.setTemplateSuffix();
> content.setKind();
>             
> I think we can improve the BigQueryServices interface by define it as:
> void insertAll(TableReference ref, Collection<TableDataInsertAllRequest> request);
> and, provided a static method to prepare requests:
> List<TableDataInsertAllRequest> makeInsertBatches(List<TableRow> rowList, @Nullable List<String> insertIdList);
> Then, client can set additional config in the returned list.
> Reference:
> GcsUtil.java has similar implementation in makeCopyBatches() and executeBatches().
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java#L550



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)