You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/04/09 18:52:43 UTC

Review Request 20170: Flume: Verify and fixes for Ganglia monitoring and metrics

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20170/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen and Sid Wagle.


Bugs: AMBARI-5408
    https://issues.apache.org/jira/browse/AMBARI-5408


Repository: ambari


Description
-------

* Adds code to make Flume agents report to Ganglia if Ganglia is available.
* Added metrics.json for FLUME service.

* I realize the hard-coded ganglia port is not good, but we have no mechanism for that lookup at this time.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metrics.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py cd3676e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py 6e65d55 
  ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 4c557ad 

Diff: https://reviews.apache.org/r/20170/diff/


Testing
-------

Running tests for stack:2.0.6 service:FLUME
test_service_check (test_service_check.TestFlumeCheck) ... ok
test_configure_default (test_flume.TestFlumeHandler) ... ok
test_start_default (test_flume.TestFlumeHandler) ... ok
test_stop_default (test_flume.TestFlumeHandler) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.068s

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:13.003s
[INFO] Finished at: Wed Apr 09 11:49:02 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 20170: Flume: Verify and fixes for Ganglia monitoring and metrics

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20170/#review39902
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On April 9, 2014, 4:52 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20170/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 4:52 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-5408
>     https://issues.apache.org/jira/browse/AMBARI-5408
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Adds code to make Flume agents report to Ganglia if Ganglia is available.
> * Added metrics.json for FLUME service.
> 
> * I realize the hard-coded ganglia port is not good, but we have no mechanism for that lookup at this time.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metrics.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py cd3676e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py 6e65d55 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 4c557ad 
> 
> Diff: https://reviews.apache.org/r/20170/diff/
> 
> 
> Testing
> -------
> 
> Running tests for stack:2.0.6 service:FLUME
> test_service_check (test_service_check.TestFlumeCheck) ... ok
> test_configure_default (test_flume.TestFlumeHandler) ... ok
> test_start_default (test_flume.TestFlumeHandler) ... ok
> test_stop_default (test_flume.TestFlumeHandler) ... ok
> 
> ----------------------------------------------------------------------
> Ran 4 tests in 0.068s
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 16:13.003s
> [INFO] Finished at: Wed Apr 09 11:49:02 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>