You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by co...@apache.org on 2002/08/08 07:34:13 UTC

cvs commit: jakarta-commons/modeler/src/java/org/apache/commons/modeler Registry.java

costin      2002/08/07 22:34:13

  Modified:    modeler/src/java/org/apache/commons/modeler Registry.java
  Log:
  Reduce verbosity. Display the message about loading the registry if the
  load time is >.5s
  
  Revision  Changes    Path
  1.3       +13 -14    jakarta-commons/modeler/src/java/org/apache/commons/modeler/Registry.java
  
  Index: Registry.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/modeler/src/java/org/apache/commons/modeler/Registry.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Registry.java	29 Jul 2002 22:25:54 -0000	1.2
  +++ Registry.java	8 Aug 2002 05:34:12 -0000	1.3
  @@ -226,7 +226,7 @@
       public synchronized static Registry getRegistry() {
   
           if (registry == null) {
  -            log.info("Creating new Registry instance");
  +            log.debug("Creating new Registry instance");
               registry = new Registry();
           }
           return (registry);
  @@ -239,18 +239,18 @@
        * <code>MBeanServer</code> instance.
        */
       public synchronized static MBeanServer getServer() {
  +        long t1=System.currentTimeMillis();
   
           if (server == null) {
               if( MBeanServerFactory.findMBeanServer(null).size() > 0 ) {
  -                log.info("Using existing MBeanServer");
                   server=(MBeanServer)MBeanServerFactory.findMBeanServer(null).get(0);
  +                log.debug("Using existing MBeanServer " + (System.currentTimeMillis() - t1 ));
               } else {
  -                log.info("Creating MBeanServer");
                   server=MBeanServerFactory.createMBeanServer();
  +                log.debug("Creating MBeanServer"+ (System.currentTimeMillis() - t1 ));
               }
           }
           return (server);
  -
       }
   
   
  @@ -265,14 +265,13 @@
        */
       public static void loadRegistry(InputStream stream)
           throws Exception {
  -
  -        log.info("Loading registry information");
  +        long t1=System.currentTimeMillis();
   
           // Create a digester to use for parsing
           Registry registry = getRegistry();
           Digester digester = new Digester();
           digester.setNamespaceAware(false);
  -        digester.setValidating(true);
  +        digester.setValidating(false); 
           URL url = registry.getClass().getResource
               ("/org/apache/commons/modeler/mbeans-descriptors.dtd");
           digester.register
  @@ -363,10 +362,11 @@
               log.error("Error digesting Registry data", e);
               throw e;
           }
  -
  +        long t2=System.currentTimeMillis();
  +        if( t2-t1 > 500 )
  +            log.info("Loaded registry information " + ( t2 - t1 ) + " ms");
       }
   
  -
       /**
        * Set the <code>MBeanServer</code> to be utilized for our
        * registered management beans.
  @@ -378,6 +378,5 @@
           server = mbeanServer;
   
       }
  -
   
   }
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>