You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/19 14:02:15 UTC

[GitHub] [pulsar] tisonkun opened a new pull request, #16683: [sql] Upgrade PrestoSQL to the first Trino version

tisonkun opened a new pull request, #16683:
URL: https://github.com/apache/pulsar/pull/16683

   **I will only continue this work if the first step seems good. You may not review this patch at the moments. Although, comments are welcome.**
   
   ### Motivation
   
   See also previous discussion at https://lists.apache.org/thread/mflm0pb5235jjk80vol0vs7v0hvowkq8.
   
   Instead of firstly create a pulsar-sql repository and highly possibly leave it uncompleted, the original pain points of maintaining Pulsar SQL (a.k.a. Pulsar Presto Connector) are:
   
   1. Pulsar (All) docker image is too large.
   2.PrestoSQL version is too old and pollutes old dependencies.
   
   Thus, I'd suggest we continuously kaizen the situation by upgrading version and decouple modules. When moving out the codebase to another repository a trivial step, we consider to do it.
   
   This patch is a small step to upgrade PrestoSQL to the first Trino version, and it contains most of the renaming work.
   
   After this change, if users running sql worker with pulsar provided scripts, the experience should be as usual. But people directly depend on pulsar-presto-connector will find the dependency is switched to Trino. I'm unsure whether or not I should write a PIP of this kaizen way.
   
   I'll treat this change at the earliest in 2.12 release train and don't rush things.
   
   ### Modifications
   
   1. Update dependencies in `pom.xml` from `io.prestosql` to `io.trino`.
   2. Update `prestosql` in code to `trino`.
   
   Fortunately, the breaking changes mentioned in #16494 aren't included in this version bump.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests. We should keep all existing test passed.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes)
   
   ### Documentation
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   
   It should be required. But leave it as is to verify CI first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1194883862

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1194105619

   Thank @merlimat for review! I push a new commit to fix license issues. Our CI doesn't check binary licenses of Pulsar SQL, though. It can be a separated issue to resolve and here is https://github.com/apache/pulsar/issues/16783.
   
   cc @MarvinCai @lhotari @codelipenghui perhaps you can also give a review on this patch and decide how to move forward?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1193041582

   If we can upgrade prestosql to trino, we may have an opportunity to rename the folder, and thus move `conf/presto` to `trino/conf` and `lib/presto/*` to `trino/*`, so that we can later smoothly move out the Pulsar SQL components.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16683:
URL: https://github.com/apache/pulsar/pull/16683


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1190999087

   This patch should be technically completed.
   
   cc @merlimat @lhotari @MarvinCai if you have spare time, please read the description above and see what direction is good to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1195007405

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1191000033

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1194853619

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1197536379

   
   /pulsarbot run-failure-checks
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1191070905

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1195007502

   I think all required tasks have passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16683: [sql] Upgrade PrestoSQL to the first Trino version

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16683:
URL: https://github.com/apache/pulsar/pull/16683#issuecomment-1197548509

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org