[jira] [Comment Edited] (JCRVLT-370) New filter option below embeddeds and subpackages which removes other versions

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948421#comment-16948421 ] 

Konrad Windszus edited comment on JCRVLT-370 at 10/10/19 11:00 AM:
-------------------------------------------------------------------

While for packages this is fairly simple as the node name has a strict format, it is less predictable with OSGi bundles. There are two plugins for building those
# maven-jar-plugin together with bnd-maven-plugin which defaults to the value of finalName (http://maven.apache.org/pom.html#BaseBuild_Element) enriched with classifier and extension
# maven-bundle-plugin is similar (http://felix.apache.org/components/bundle-plugin/bundle-mojo.html#finalName)

For both cases user's can override the value.
But I guess it should be enough to do a test against a default regex and fail in case the embedded file name does not match it.


was (Author: kwin):
While for packages this is fairly simple as the node name has a strict format, it is less predictable with OSGi bundles. There are two plugins for building those
# maven-jar-plugin together with bnd-maven-plugin which defaults to the value of finalName (http://maven.apache.org/pom.html#BaseBuild_Element) enriched with classifier and extension
# maven-bundle-plugin is similar (http://felix.apache.org/components/bundle-plugin/bundle-mojo.html#finalName)
On both cases user's can override the value.
But I guess it should be enough to do a test against a default regex and fail in case the embedded file name does not match it.

> New filter option below embeddeds and subpackages which removes other versions
> ------------------------------------------------------------------------------
>
>                 Key: JCRVLT-370
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-370
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: package maven plugin
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: package-maven-plugin-1.0.5
>
>
> Currently if the {{filter}} option is set below embeddeds or subpackages a very specific filter entry is added to the filter.xml. That leads to the fact that other versions of the same package are not getting removed.
> Very often in a CI environment it is desired to remove all other versions, therefore I propose to add another option {{filterWithoutVersion}} which will make sure that OSGi bundles with the same name but another version and sub packages with the same name and group but another version are still removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)