[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6815: pic32mx: add option to disable JTAG at runtime

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #6815:
URL: https://github.com/apache/incubator-nuttx/pull/6815#discussion_r940853842


##########
arch/mips/src/pic32mx/pic32mx_lowinit.c:
##########
@@ -155,6 +156,60 @@ static inline void pic32mx_cache(void)
   asm("\tmtc0 %0,$16,0\n" : : "r" (regval));
 }
 
+/****************************************************************************
+ * Name: pic32mx_disable_jtag
+ *
+ * Description:
+ *   Disable the JTAG connection
+ *
+ * Assumptions:
+ *   Interrupts are disabled.
+ *
+ ****************************************************************************/
+
+static inline void pic32mx_disable_jtag(void)

Review Comment:
   Should new interfaces be wrapped with ifdef to avoid compilation warning about unused code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org