[jira] [Commented] (NIFI-2999) In NiFI Cluster, new cluster coordinator election could result in all nodes being dropped.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657442#comment-15657442 ] 

ASF GitHub Bot commented on NIFI-2999:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/1210

    NIFI-2999: When Cluster Coordinator changes, purge any old heartbeats…

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    … so that we don't disconnect a node due to very old heartbeats

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-2999

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1210
    
----
commit 0c81421bdda3cd8e748845d4cff826397f8854d4
Author: Mark Payne <ma...@hotmail.com>
Date:   2016-11-11T16:11:36Z

    NIFI-2999: When Cluster Coordinator changes, purge any old heartbeats so that we don't disconnect a node due to very old heartbeats

----


> In NiFI Cluster, new cluster coordinator election could result in all nodes being dropped.
> ------------------------------------------------------------------------------------------
>
>                 Key: NIFI-2999
>                 URL: https://issues.apache.org/jira/browse/NIFI-2999
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0
>            Reporter: Matthew Clarke
>
> When NiFi elects a new cluster coordinator, the newly elected coordinator starts accepting heartbeats from the cluster nodes. If another cluster coordinator election occurs later which results in the original Node being elected as the cluster coordinator once again, old heartbeat messages exist which will trigger all nodes to be dropped due to their age exceeding the threshold for last received heartbeat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)