You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2010/01/18 18:54:54 UTC

[jira] Resolved: (WICKET-2684) Provide a way to disable "Child component has a non-safe child id"

     [ https://issues.apache.org/jira/browse/WICKET-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2684.
-----------------------------------

    Resolution: Invalid
      Assignee: Igor Vaynberg

>One of examples is user list with login acting as primary key on a stateless page. 
>Relying on index is fragile because users can be added/deleted by other requests,
> so i want to use user login as repeater child ids, however it triggers warning. 

this doesnt make any sense. users being added/removed from the database does not affect this at all. the flow is like this:

1) user clicks delete link #10.
2) wicket finds delete link #10 and invokes onsubmit
3) inside onsubmit user does: service.delete(getmodel().getobject())

it is the model assigned to link that contains the PK of the user, the PK does not come from the index of the link.

> Provide a way to disable "Child component  has a non-safe child id"
> -------------------------------------------------------------------
>
>                 Key: WICKET-2684
>                 URL: https://issues.apache.org/jira/browse/WICKET-2684
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.5
>            Reporter: Marat Radchenko
>            Assignee: Igor Vaynberg
>
> AbstractRepeater.onBeforeRender checks child component ids to be digit-only. While i (kinda) understand reasoning behind this behavior, it is sometimes not what i want.
> One of examples is user list with login acting as primary key on a stateless page. Relying on index is fragile because users can be added/deleted by other requests, so i want to use user login as repeater child ids, however it triggers warning.
> That check should be either disableable globally or on per-component basis (latter is more desired), so I can tell AbstractRepeater that i know what i'm doing and deliberately want non-numeric ids.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.