[jira] [Commented] (CALCITE-3093) Remove JDBC connection calls from PlannerImpl

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849065#comment-16849065 ] 

Julian Hyde commented on CALCITE-3093:
--------------------------------------

I reviewed the PR.
* It is a useful set of refactorings, and we should do it. But the title "Remove JDBC connection calls from PlannerImpl" no longer seems to be a good description of the change as the commit message. The new system properties are probably the most significant part of the change.
* You mis-spelled Calcite in a couple of places. Search for "calite".
* Maybe mark the new rule sets as experimental? Just a thought.

> Remove JDBC connection calls from PlannerImpl
> ---------------------------------------------
>
>                 Key: CALCITE-3093
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3093
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Hongze Zhang
>            Assignee: Hongze Zhang
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the class {{PlannerImpl}} creates JDBC connections[1] internally to instantiate {{RelOptPlanner}}. For improving the design I suggest to reverse the call chain, for example, we can make JDBC API call PlannerImpl to create {{RelOptPlanner}}, {{SqlValidator}}, {{SqlToRelConverter}} instances, etc.
> This JIRA topic is the first step of the improvement - we should decouple the use of JDBC API from PlannerImpl. Planner API is designed to be a reusable toolkit and we should make it work individually without the help of JDBC API.
> [1] https://github.com/apache/calcite/blob/4e1b68e3c0b2a90832cc790c6166cebb14ae2970/core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java#L143-L151



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)