You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/03/19 13:02:54 UTC
[GitHub] [spark] panbingkun opened a new pull request, #40476: [WIP][MINOR][BUILD] Remove unused properties in pom file
panbingkun opened a new pull request, #40476:
URL: https://github.com/apache/spark/pull/40476
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40476: [WIP][MINOR][BUILD] Remove unused properties in pom file
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40476:
URL: https://github.com/apache/spark/pull/40476#discussion_r1141356905
##########
resource-managers/kubernetes/integration-tests/pom.xml:
##########
@@ -26,8 +26,6 @@
<artifactId>spark-kubernetes-integration-tests_2.12</artifactId>
<properties>
- <download-maven-plugin.version>1.3.0</download-maven-plugin.version>
Review Comment:
cc @Yikun FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #40476: [WIP][MINOR][BUILD] Remove unused properties in pom file
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #40476:
URL: https://github.com/apache/spark/pull/40476#discussion_r1141395575
##########
resource-managers/kubernetes/integration-tests/pom.xml:
##########
@@ -26,8 +26,6 @@
<artifactId>spark-kubernetes-integration-tests_2.12</artifactId>
<properties>
- <download-maven-plugin.version>1.3.0</download-maven-plugin.version>
- <extraScalaTestArgs></extraScalaTestArgs>
Review Comment:
I think at some point we added things like this explicitly to override test args to be empty, because they were non-empty in the parent or something. I don't know if this is still the case though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #40476: [WIP][MINOR][BUILD] Remove unused properties in pom file
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #40476:
URL: https://github.com/apache/spark/pull/40476#discussion_r1141562155
##########
resource-managers/kubernetes/integration-tests/pom.xml:
##########
@@ -26,8 +26,6 @@
<artifactId>spark-kubernetes-integration-tests_2.12</artifactId>
<properties>
- <download-maven-plugin.version>1.3.0</download-maven-plugin.version>
- <extraScalaTestArgs></extraScalaTestArgs>
Review Comment:
According to my inspection, the `extraScalaTestArgs` parameter no longer exists in the project.
<img width="849" alt="image" src="https://user-images.githubusercontent.com/15246973/226231904-0af68136-3c2f-45c4-9f6f-9d0f50dcbe0d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40476: [MINOR][BUILD] Remove unused properties in pom file
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40476:
URL: https://github.com/apache/spark/pull/40476#issuecomment-1476258173
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #40476: [MINOR][BUILD] Remove unused properties in pom file
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #40476: [MINOR][BUILD] Remove unused properties in pom file
URL: https://github.com/apache/spark/pull/40476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a diff in pull request #40476: [MINOR][BUILD] Remove unused properties in pom file
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #40476:
URL: https://github.com/apache/spark/pull/40476#discussion_r1142823591
##########
resource-managers/kubernetes/integration-tests/pom.xml:
##########
@@ -26,8 +26,6 @@
<artifactId>spark-kubernetes-integration-tests_2.12</artifactId>
<properties>
- <download-maven-plugin.version>1.3.0</download-maven-plugin.version>
- <extraScalaTestArgs></extraScalaTestArgs>
Review Comment:
So my guess is that `extraScalaTestArgs` can be helpful for local build/test for developers to add some custom java options, agents, etc. It just defaults to empty, not useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #40476: [MINOR][BUILD] Remove unused properties in pom file
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #40476:
URL: https://github.com/apache/spark/pull/40476#discussion_r1141563736
##########
resource-managers/kubernetes/integration-tests/pom.xml:
##########
@@ -26,8 +26,6 @@
<artifactId>spark-kubernetes-integration-tests_2.12</artifactId>
<properties>
- <download-maven-plugin.version>1.3.0</download-maven-plugin.version>
- <extraScalaTestArgs></extraScalaTestArgs>
Review Comment:
OK looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org