[GitHub] [flink-docker] KarlManong commented on a diff in pull request #117: [FLINK-28057] Fix LD_PRELOAD on ARM images

[GitBox <gi...@apache.org>]

KarlManong commented on code in PR #117:
URL: https://github.com/apache/flink-docker/pull/117#discussion_r912330737


##########
docker-entrypoint.sh:
##########
@@ -91,7 +91,12 @@ prepare_configuration() {
 
 maybe_enable_jemalloc() {
     if [ "${DISABLE_JEMALLOC:-false}" == "false" ]; then
-        export LD_PRELOAD=$LD_PRELOAD:/usr/lib/x86_64-linux-gnu/libjemalloc.so
+        # Maybe use export LD_PRELOAD=$LD_PRELOAD:/usr/lib/$(uname -i)-linux-gnu/libjemalloc.so
+        if [[ `uname -i` == 'aarch64' ]]; then
+            export LD_PRELOAD=$LD_PRELOAD:/usr/lib/aarch64-linux-gnu/libjemalloc.so

Review Comment:
   why not using `$(uname -m)` directly in the line?
   
   such as 
   ```
   export LD_PRELOAD=$LD_PRELOAD:/usr/lib/$(uname -m)-linux-gnu/libjemalloc.so
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org