You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/07/03 19:06:31 UTC
Review Request 67809: Added per-framework metrics for scheduler
events.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8844
https://issues.apache.org/jira/browse/MESOS-8844
Repository: mesos
Description
-------
Added per-framework metrics for scheduler events.
Diffs
-----
src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67809/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67809: Added per-framework metrics for scheduler
events.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/#review205823
-----------------------------------------------------------
Fix it, then Ship it!
src/master/metrics.hpp
Lines 238 (patched)
<https://reviews.apache.org/r/67809/#comment288728>
Let's name this `update_event_task_states`.
src/master/metrics.cpp
Lines 678 (patched)
<https://reviews.apache.org/r/67809/#comment288729>
Let's add a CHECK here like the one in #672.
- Gastón Kleiman
On July 6, 2018, 11:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67809/
> -----------------------------------------------------------
>
> (Updated July 6, 2018, 11:01 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8844
> https://issues.apache.org/jira/browse/MESOS-8844
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for scheduler events.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67809/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67809: Added per-framework metrics for scheduler
events.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/#review206226
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.hpp
Lines 2473 (patched)
<https://reviews.apache.org/r/67809/#comment289113>
Nit: s/message/the message/ ?
src/master/metrics.cpp
Lines 585-587 (patched)
<https://reviews.apache.org/r/67809/#comment289114>
Nit: I think I prefer adding the aggregate counter (`events`) and the per-type counters together, similar to how the destructor is structured.
But both ways are readable, so feel free to drop this issue =).
- Gastón Kleiman
On July 17, 2018, 6:34 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67809/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 6:34 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8844
> https://issues.apache.org/jira/browse/MESOS-8844
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for scheduler events.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67809/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67809: Added per-framework metrics for scheduler
events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/
-----------------------------------------------------------
(Updated July 24, 2018, 5:57 p.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-8844
https://issues.apache.org/jira/browse/MESOS-8844
Repository: mesos
Description
-------
Added per-framework metrics for scheduler events.
Diffs (updated)
-----
src/master/master.hpp 0353d550308816f219aedb6afe15c643fc8bb340
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67809/diff/5/
Changes: https://reviews.apache.org/r/67809/diff/4-5/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67809: Added per-framework metrics for scheduler
events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/
-----------------------------------------------------------
(Updated July 20, 2018, 8:56 p.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8844
https://issues.apache.org/jira/browse/MESOS-8844
Repository: mesos
Description
-------
Added per-framework metrics for scheduler events.
Diffs (updated)
-----
src/master/master.hpp 0353d550308816f219aedb6afe15c643fc8bb340
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67809/diff/4/
Changes: https://reviews.apache.org/r/67809/diff/3-4/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67809: Added per-framework metrics for scheduler
events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/
-----------------------------------------------------------
(Updated July 18, 2018, 1:34 a.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Changes
-------
Eliminated the per-task-state update event metrics.
Bugs: MESOS-8844
https://issues.apache.org/jira/browse/MESOS-8844
Repository: mesos
Description
-------
Added per-framework metrics for scheduler events.
Diffs (updated)
-----
src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67809/diff/3/
Changes: https://reviews.apache.org/r/67809/diff/2-3/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67809: Added per-framework metrics for scheduler
events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/
-----------------------------------------------------------
(Updated July 9, 2018, 6:17 p.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8844
https://issues.apache.org/jira/browse/MESOS-8844
Repository: mesos
Description
-------
Added per-framework metrics for scheduler events.
Diffs (updated)
-----
src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67809/diff/2/
Changes: https://reviews.apache.org/r/67809/diff/1-2/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67809: Added per-framework metrics for scheduler
events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/
-----------------------------------------------------------
(Updated July 6, 2018, 6:01 p.m.)
Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8844
https://issues.apache.org/jira/browse/MESOS-8844
Repository: mesos
Description
-------
Added per-framework metrics for scheduler events.
Diffs
-----
src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67809/diff/1/
Testing
-------
Thanks,
Greg Mann