You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@iotdb.apache.org by "divinerapier (via GitHub)" <gi...@apache.org> on 2025/06/12 07:24:18 UTC
[PR] Fix Go module name: add /v2 suffix [iotdb-client-go]
divinerapier opened a new pull request, #132:
URL: https://github.com/apache/iotdb-client-go/pull/132
## Changes
Updated the go.mod file to include the /v2 suffix in the module path, following Go Modules versioning requirements (i.e., module github.com/apache/iotdb-client-go/v2).
This change ensures that users can correctly fetch v2+ versions using go get github.com/apache/iotdb-client-go/v2, and prevents dependency issues caused by an incorrect module path.
Fix #131
## Motivation
According to Go Modules best practices, when the major version is v2 or higher, the module path must include the /v2 suffix. Omitting this leads to problems with dependency management and import resolution.
With this fix, users can properly import and upgrade to v2+ versions of the SDK as recommended by the Go team.
## Impact
This change only affects the go.mod file and import paths; there are no functional code changes.
Downstream users depending on v2+ of this project will need to update their import paths to github.com/apache/iotdb-client-go/v2.
## References
[Go Modules: Version Numbers](https://go.dev/doc/modules/version-numbers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Go module name: add /v2 suffix [iotdb-client-go]
Posted by "divinerapier (via GitHub)" <gi...@apache.org>.
divinerapier commented on PR #132:
URL: https://github.com/apache/iotdb-client-go/pull/132#issuecomment-2989584372
@shuwenwei
<img width="738" alt="截屏2025-06-20 09 48 59" src="https://github.com/user-attachments/assets/fe93a520-d878-434a-9480-c0ef92dc5f79" />
PTAL, Makefile was updated and e2e test is ok. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Go module name: add /v2 suffix [iotdb-client-go]
Posted by "shuwenwei (via GitHub)" <gi...@apache.org>.
shuwenwei merged PR #132:
URL: https://github.com/apache/iotdb-client-go/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Go module name: add /v2 suffix [iotdb-client-go]
Posted by "shuwenwei (via GitHub)" <gi...@apache.org>.
shuwenwei commented on PR #132:
URL: https://github.com/apache/iotdb-client-go/pull/132#issuecomment-2983421116
Some files are generated by thrift and the Makefile(https://github.com/apache/iotdb-client-go/blob/main/Makefile) also needs to be modified.
<img width="1395" alt="截屏2025-06-18 17 32 19" src="https://github.com/user-attachments/assets/8dcc2cb4-9fd9-48df-91ce-eec6aecfe336" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org