You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/13 12:53:15 UTC

[GitHub] [pulsar] nicoloboschi opened a new pull request #13272: Align configurations defaults between default file and Java object (broker.conf, proxy.conf, websocket.conf)

nicoloboschi opened a new pull request #13272:
URL: https://github.com/apache/pulsar/pull/13272


   Based on #13268 
   ### Motivation
   
   In the default configuration files `conf/broker.conf`, `conf/proxy.conf` and `conf/websocket.conf` some entries are set with a value which differs from the Java one.
   
   So if you comment out or you remove that line in the configuration file, the behavior changes.
   
   ### Modifications
   
   * Aligned some Java properties to the file's value. Likely the user will not comment out the config lines so the expected behavior is that the config file contains the default values.
   * Added tests to avoid future regressions 
   
   ### Does this pull request potentially affect one of the following parts:
   
    - The default values of configurations: yes
    
   ### Documentation
   
   - [x] `doc` 
    
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #13272: Align configurations defaults between default file and Java object (broker.conf, proxy.conf, websocket.conf)

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #13272:
URL: https://github.com/apache/pulsar/pull/13272#issuecomment-992727909


   @eolivelli @codelipenghui PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on a change in pull request #13272: Align configurations defaults between default file and Java object (broker.conf, proxy.conf, websocket.conf)

Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #13272:
URL: https://github.com/apache/pulsar/pull/13272#discussion_r768227379



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -576,7 +576,7 @@
         category = CATEGORY_POLICIES,
         doc = "How often is the thread pool scheduled to check whether a snapshot needs to be taken.(disable with value 0)"
     )
-    private int brokerDeduplicationSnapshotFrequencyInSeconds = 120;
+    private int brokerDeduplicationSnapshotFrequencyInSeconds = 10;

Review comment:
       We need to fix these, but we need to fix them with default that make sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #13272: Align configurations defaults between default file and Java object (broker.conf, proxy.conf, websocket.conf)

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #13272:
URL: https://github.com/apache/pulsar/pull/13272#issuecomment-993300948


   @merlimat I addressed your comments. I also added a table in the PR description to better understand the configuration changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on a change in pull request #13272: Align configurations defaults between default file and Java object (broker.conf, proxy.conf, websocket.conf)

Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #13272:
URL: https://github.com/apache/pulsar/pull/13272#discussion_r767995482



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -933,7 +933,7 @@
     @FieldContext(
         category = CATEGORY_SERVER,
         doc = "Number of worker threads to serve non-persistent topic")
-    private int numWorkerThreadsForNonPersistentTopic = Runtime.getRuntime().availableProcessors();
+    private int numWorkerThreadsForNonPersistentTopic = 8;

Review comment:
       This is done to use the number of available core. We must not change it.

##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -576,7 +576,7 @@
         category = CATEGORY_POLICIES,
         doc = "How often is the thread pool scheduled to check whether a snapshot needs to be taken.(disable with value 0)"
     )
-    private int brokerDeduplicationSnapshotFrequencyInSeconds = 120;
+    private int brokerDeduplicationSnapshotFrequencyInSeconds = 10;

Review comment:
       10 seconds is too low. We should not change the 2 min




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on a change in pull request #13272: Align configurations defaults between default file and Java object (broker.conf, proxy.conf, websocket.conf)

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #13272:
URL: https://github.com/apache/pulsar/pull/13272#discussion_r768031961



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -576,7 +576,7 @@
         category = CATEGORY_POLICIES,
         doc = "How often is the thread pool scheduled to check whether a snapshot needs to be taken.(disable with value 0)"
     )
-    private int brokerDeduplicationSnapshotFrequencyInSeconds = 120;
+    private int brokerDeduplicationSnapshotFrequencyInSeconds = 10;

Review comment:
       This is value set in the broker.conf so it is the value used by default. The goal of this patch is not providing better defaults but to keep consistency if a user remove a configuration line. It is expected the values in the broker.conf are the default ones and not an "improved configuration". Do you agree?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #13272: Align configurations defaults between default file and Java object (broker.conf, proxy.conf, websocket.conf)

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #13272:
URL: https://github.com/apache/pulsar/pull/13272


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org