[GitHub] [commons-fileupload] kinow commented on pull request #75: FILEUPLOAD-323 - Implement spotbugs

[GitBox <gi...@apache.org>]

kinow commented on pull request #75:
URL: https://github.com/apache/commons-fileupload/pull/75#issuecomment-829999881


   Hi @jochenw 
   
   I also don't have a strong preference. Most times I just try to remember to read some code in the project I'm working on and mimic the code style.
   
   I find SpotBugs/checkstyle/etc helpful when we find a set of rules that allow you to spot simple mistakes, especially those that appear in PR's of first-time contributors, and can be quickly spotted by CI. But agree that some rules can be annoying (e.g. when you wrote a perfectly legible 121 characters line, and checkstyle tells you to reduce in character or add a line break 🤷‍♂️ ).
   
   I think this PR can be a good initial work for spotbugs. We can tweak it so that it doesn't bother you and others when they need to work on the component, whilst also helping you and other devs to keep the code uniform-ish, and filter simple bugs in CI (i.e. feel free to suggest what rules are being helpful or not, what to disable, etc).
   
   Just my 0.02 cents :o)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org