You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/06/16 22:23:17 UTC
[kudu-CR] Add Raft remote bootstrap design doc
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3395
to review the following change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Add Raft remote bootstrap design doc
This was ported over from a Google doc
Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
---
M docs/design-docs/README.md
A docs/design-docs/raft-remote-bootstrap.md
2 files changed, 346 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/3395/1
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Patch Set 2:
Updated HTML: https://github.com/mpercy/kudu/blob/consensus-docs-3a/docs/design-docs/raft-remote-bootstrap.md
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/1848/
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/1857/
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Add Raft remote bootstrap design doc
This was ported over from a Google doc
Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Reviewed-on: http://gerrit.cloudera.org:8080/3395
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/design-docs/README.md
A docs/design-docs/raft-remote-bootstrap.md
2 files changed, 344 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Patch Set 2:
(4 comments)
Looks good, just a few formatting nits.
http://gerrit.cloudera.org:8080/#/c/3395/2/docs/design-docs/raft-remote-bootstrap.md
File docs/design-docs/raft-remote-bootstrap.md:
PS2, Line 108: `DOES_NOT_EXIST` or is
: `DELETED`
This highlighting looks good for states in the state machine. Could you add it to other references to DOES_NOT_EXIST or DELETED elsewhere in the doc, provided they're not in a verbatim section?
Would be good for other state names too, like COPYING.
Line 187: 2. mkdir quarantine directory (QDIR).
Nit: none of the other UNIX-y operations in this list are referenced by their UNIX-y name, so can you change this to "Create the quarantine directory (QDIR)"?
Line 257: 1. Master sends an AddServer() RPC to the leader of the tablet to add a new
Nit: a singleton list is just noise, could you remove the "1." prefix?
PS2, Line 260: a. This AddServer() RPC will specify the prior committed raft config for the
: tablet to ensure that the request is idempotent.
Unfortunately, GH markdown requires that sublists be numeric too. Otherwise it doesn't render them as a list.
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/3395/2/docs/design-docs/raft-remote-bootstrap.md
File docs/design-docs/raft-remote-bootstrap.md:
PS2, Line 108: `DOES_NOT_EXIST` or is
: `DELETED`
> This highlighting looks good for states in the state machine. Could you add
Done
Line 187: 2. mkdir quarantine directory (QDIR).
> Nit: none of the other UNIX-y operations in this list are referenced by the
Done
Line 257: 1. Master sends an AddServer() RPC to the leader of the tablet to add a new
> Nit: a singleton list is just noise, could you remove the "1." prefix?
Done
PS2, Line 260: a. This AddServer() RPC will specify the prior committed raft config for the
: tablet to ensure that the request is idempotent.
> Unfortunately, GH markdown requires that sublists be numeric too. Otherwise
Done
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/1844/
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/1843/
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#2).
Change subject: Add Raft remote bootstrap design doc
......................................................................
Add Raft remote bootstrap design doc
This was ported over from a Google doc
Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
---
M docs/design-docs/README.md
A docs/design-docs/raft-remote-bootstrap.md
2 files changed, 343 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/3395/2
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
......................................................................
Patch Set 2:
See the rendered page at https://github.com/mpercy/kudu/blob/consensus-docs-3/docs/design-docs/raft-remote-bootstrap.md
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add Raft remote bootstrap design doc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3395
to look at the new patch set (#3).
Change subject: Add Raft remote bootstrap design doc
......................................................................
Add Raft remote bootstrap design doc
This was ported over from a Google doc
Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
---
M docs/design-docs/README.md
A docs/design-docs/raft-remote-bootstrap.md
2 files changed, 344 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/3395/3
--
To view, visit http://gerrit.cloudera.org:8080/3395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2c28
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>