[GitHub] [airflow] potiuk commented on a diff in pull request #25449: Move breeze commands to sub-commands

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #25449:
URL: https://github.com/apache/airflow/pull/25449#discussion_r934933241


##########
dev/breeze/src/airflow_breeze/configure_rich_click.py:
##########
@@ -20,26 +20,27 @@
     # We handle ImportError so that click autocomplete works
     import rich_click as click
 
-    from airflow_breeze.commands.ci_commands import CI_COMMANDS, CI_PARAMETERS
-    from airflow_breeze.commands.ci_image_commands import CI_IMAGE_TOOLS_COMMANDS, CI_IMAGE_TOOLS_PARAMETERS
-    from airflow_breeze.commands.configuration_and_maintenance_commands import (
-        CONFIGURATION_AND_MAINTENANCE_COMMANDS,
-        CONFIGURATION_AND_MAINTENANCE_PARAMETERS,
+    from airflow_breeze.commands.ci_commands_config import CI_COMMANDS, CI_PARAMETERS

Review Comment:
   The 'else' on anything than if is a lesser-known Python-only trick. A lot of people do not now it. I actually learned about it few weeks ago and while it feels more pythonic, for most people it is a bit alien. 
   
   But, even with those reservation, I am all for incresing awareness of `else` beyond if so why not :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org