You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/18 16:41:16 UTC
[GitHub] [arrow] jhorstmann commented on a change in pull request #8485: ARROW-10002: [Rust] Remove trait specialization from arrow crate
jhorstmann commented on a change in pull request #8485:
URL: https://github.com/apache/arrow/pull/8485#discussion_r507184621
##########
File path: rust/arrow/src/array/builder.rs
##########
@@ -253,8 +253,18 @@ pub trait BufferBuilderTrait<T: ArrowPrimitiveType> {
}
impl<T: ArrowPrimitiveType> BufferBuilderTrait<T> for BufferBuilder<T> {
- default fn new(capacity: usize) -> Self {
- let buffer = MutableBuffer::new(capacity * mem::size_of::<T::Native>());
+ #[inline]
+ fn new(capacity: usize) -> Self {
+ let buffer = if T::DATA_TYPE == DataType::Boolean {
Review comment:
Nice! I used a similar trick for the simd sum aggregation that the compiler was also able to optimize away (https://github.com/apache/arrow/pull/8370/files#diff-53a8522c4a482c9566b9032e1bd2c7990bab29640857cb40411beb7158189e75R625)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org