You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/21 00:56:31 UTC
[GitHub] [spark] wenxuanguan commented on a change in pull request #24631:
[SPARK-27774][CORE][EXAMPLES][MLLIB] Avoid hardcoded configs
wenxuanguan commented on a change in pull request #24631: [SPARK-27774][CORE][EXAMPLES][MLLIB] Avoid hardcoded configs
URL: https://github.com/apache/spark/pull/24631#discussion_r285817345
##########
File path: examples/src/main/scala/org/apache/spark/examples/mllib/MovieLensALS.scala
##########
@@ -24,6 +24,7 @@ import org.apache.log4j.{Level, Logger}
import scopt.OptionParser
import org.apache.spark.{SparkConf, SparkContext}
+import org.apache.spark.internal.config.Kryo._
Review comment:
@srowen That make sense, revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org