[GitHub] [hive] zabetak commented on a diff in pull request #3295: HIVE-26233: Problems reading back PARQUET timestamps above 10000 years

[GitBox <gi...@apache.org>]

zabetak commented on code in PR #3295:
URL: https://github.com/apache/hive/pull/3295#discussion_r878923538


##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java:
##########
@@ -389,6 +390,26 @@ public void testIllegalInt64TimestampStrings() {
     verifyInt64TimestampValue("2262-04-11 23:47:16.854775808", LogicalTypeAnnotation.TimeUnit.NANOS, false);
   }
 
+  @Test

Review Comment:
   The test passes successfully if you exclude all the changes in this PR and revert some lines in `NanoTimeUtils` as I mentioned in the JIRA case. This makes me think that we need to treat the problem differently since it does not appear to be related to the formatter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org