You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/04/13 09:39:43 UTC
Review Request 58414: Different global variable saved the same
configuration
file path in unixauthservice. The code logic is inconsistent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58414/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1511
https://issues.apache.org/jira/browse/RANGER-1511
Repository: ranger
Description
-------
Different global variable saved the same configuration file path in unixauthservice. The code logic is inconsistent.
Diffs
-----
unixauthservice/scripts/setup.py c7aa959
Diff: https://reviews.apache.org/r/58414/diff/1/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 58414: Different global variable saved the same
configuration file path in unixauthservice. The code logic is inconsistent.
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On \u56db\u6708 13, 2017, 11:55 a.m., Colm O hEigeartaigh wrote:
> > What is the difference if any between "os.path.join" and simply "join" here?
from os.path import isfile, join, dirname, basename
In above clause we can see that the corresponding module has been imported. So the os.path can be ingored. In the program some clauses use the os.path, while others do not use the os.path. We should also be consistent in these clauses.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58414/#review171858
-----------------------------------------------------------
On \u56db\u6708 13, 2017, 9:39 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58414/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 13, 2017, 9:39 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1511
> https://issues.apache.org/jira/browse/RANGER-1511
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Different global variable saved the same configuration file path in unixauthservice. The code logic is inconsistent.
>
>
> Diffs
> -----
>
> unixauthservice/scripts/setup.py c7aa959
>
>
> Diff: https://reviews.apache.org/r/58414/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 58414: Different global variable saved the same
configuration file path in unixauthservice. The code logic is inconsistent.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58414/#review171858
-----------------------------------------------------------
What is the difference if any between "os.path.join" and simply "join" here?
- Colm O hEigeartaigh
On April 13, 2017, 9:39 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58414/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 9:39 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1511
> https://issues.apache.org/jira/browse/RANGER-1511
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Different global variable saved the same configuration file path in unixauthservice. The code logic is inconsistent.
>
>
> Diffs
> -----
>
> unixauthservice/scripts/setup.py c7aa959
>
>
> Diff: https://reviews.apache.org/r/58414/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 58414: Different global variable saved the same
configuration file path in unixauthservice. The code logic is inconsistent.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58414/#review171863
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 13, 2017, 9:39 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58414/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 9:39 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1511
> https://issues.apache.org/jira/browse/RANGER-1511
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Different global variable saved the same configuration file path in unixauthservice. The code logic is inconsistent.
>
>
> Diffs
> -----
>
> unixauthservice/scripts/setup.py c7aa959
>
>
> Diff: https://reviews.apache.org/r/58414/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>