You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Carlos Rovira <ca...@apache.org> on 2020/01/27 15:06:43 UTC

[VSCode - asconfigc] sdk referenced in tasks.json

Hi,

recently in TDJ I changed asconfigc task to use this:

"windows": {
"args": [
"--sdk=C:\\Apache\\royale-asjs"
]
},
"osx": {
"args": [
"--sdk=${env:ROYALE_HOME}"
]
},

to this :

"args": [
"--sdk=${config:as3mxml.sdk.framework}"
],

I want to propose to change in all framework, unless someone see some
problem in doing that, avoiding the hardcoded paths for windows or depend
on ROYALE_HOME, that users could not have set.
I asume that asconfigc is used by people using VSCode so they have
settings.json with as3mxml.sdk.framework defined

-- 
Carlos Rovira
http://about.me/carlosrovira

Re: [VSCode - asconfigc] sdk referenced in tasks.json

Posted by Carlos Rovira <ca...@apache.org>.
Hi Josh,
it seems ok to me. If nobody has nothing in the next hour or so, I'll do
the change
thanks

El lun., 27 ene. 2020 a las 17:00, Josh Tynjala (<jo...@bowlerhat.dev>)
escribió:

> If the projects in the Royale repos include .vscode/tasks.json, they should
> use the built-in tasks that are provided by the extension.
>
> {
>     "type": "actionscript",
>     "debug": true,
>     "problemMatcher": [],
>     "group": "build"
> },
> {
>     "type": "actionscript",
>     "debug": false,
>     "problemMatcher": [],
>     "group": "build"
> }
>
> We should not require users to install asconfigc from npm. It's an extra
> step that adds unnecessary complexity for new contributors.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Mon, Jan 27, 2020 at 7:07 AM Carlos Rovira <ca...@apache.org>
> wrote:
>
> > Hi,
> >
> > recently in TDJ I changed asconfigc task to use this:
> >
> > "windows": {
> > "args": [
> > "--sdk=C:\\Apache\\royale-asjs"
> > ]
> > },
> > "osx": {
> > "args": [
> > "--sdk=${env:ROYALE_HOME}"
> > ]
> > },
> >
> > to this :
> >
> > "args": [
> > "--sdk=${config:as3mxml.sdk.framework}"
> > ],
> >
> > I want to propose to change in all framework, unless someone see some
> > problem in doing that, avoiding the hardcoded paths for windows or depend
> > on ROYALE_HOME, that users could not have set.
> > I asume that asconfigc is used by people using VSCode so they have
> > settings.json with as3mxml.sdk.framework defined
> >
> > --
> > Carlos Rovira
> > http://about.me/carlosrovira
> >
>


-- 
Carlos Rovira
http://about.me/carlosrovira

Re: [VSCode - asconfigc] sdk referenced in tasks.json

Posted by Josh Tynjala <jo...@bowlerhat.dev>.
If the projects in the Royale repos include .vscode/tasks.json, they should
use the built-in tasks that are provided by the extension.

{
    "type": "actionscript",
    "debug": true,
    "problemMatcher": [],
    "group": "build"
},
{
    "type": "actionscript",
    "debug": false,
    "problemMatcher": [],
    "group": "build"
}

We should not require users to install asconfigc from npm. It's an extra
step that adds unnecessary complexity for new contributors.

--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>


On Mon, Jan 27, 2020 at 7:07 AM Carlos Rovira <ca...@apache.org>
wrote:

> Hi,
>
> recently in TDJ I changed asconfigc task to use this:
>
> "windows": {
> "args": [
> "--sdk=C:\\Apache\\royale-asjs"
> ]
> },
> "osx": {
> "args": [
> "--sdk=${env:ROYALE_HOME}"
> ]
> },
>
> to this :
>
> "args": [
> "--sdk=${config:as3mxml.sdk.framework}"
> ],
>
> I want to propose to change in all framework, unless someone see some
> problem in doing that, avoiding the hardcoded paths for windows or depend
> on ROYALE_HOME, that users could not have set.
> I asume that asconfigc is used by people using VSCode so they have
> settings.json with as3mxml.sdk.framework defined
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>