You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/03/04 19:36:26 UTC
[kudu-CR] build: fix ar flags to avoid a warning on newer OSes
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9486
to review the following change.
Change subject: build: fix ar flags to avoid a warning on newer OSes
......................................................................
build: fix ar flags to avoid a warning on newer OSes
726514abfe309b0b88a5d868129f494c379af954 enabled thin linking by
modifying the flags passed to 'ar' to 'cruT'. This caused the following
warning on my Ubuntu 16 box:
ar: `u' modifier ignored since `D' is the default (see `U')
I checked the CMake source and found that the default 'ar' command line
is:
set(CMAKE_C_ARCHIVE_CREATE "<CMAKE_AR> qc <TARGET> <LINK_FLAGS> <OBJECTS>")
So, I think it's more appropriate to use 'qcT' instead of 'cruT' ('T' is
the flag which enables the thin libraries). I verified that this still
produces thin libraries and the warnings are gone.
Change-Id: Icef2ba9336196e13cbc43508720874442c3b4460
---
M CMakeLists.txt
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/9486/1
--
To view, visit http://gerrit.cloudera.org:8080/9486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icef2ba9336196e13cbc43508720874442c3b4460
Gerrit-Change-Number: 9486
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] build: fix ar flags to avoid a warning on newer OSes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9486 )
Change subject: build: fix ar flags to avoid a warning on newer OSes
......................................................................
build: fix ar flags to avoid a warning on newer OSes
726514abfe309b0b88a5d868129f494c379af954 enabled thin linking by
modifying the flags passed to 'ar' to 'cruT'. This caused the following
warning on my Ubuntu 16 box:
ar: `u' modifier ignored since `D' is the default (see `U')
I checked the CMake source and found that the default 'ar' command line
is:
set(CMAKE_C_ARCHIVE_CREATE "<CMAKE_AR> qc <TARGET> <LINK_FLAGS> <OBJECTS>")
So, I think it's more appropriate to use 'qcT' instead of 'cruT' ('T' is
the flag which enables the thin libraries). I verified that this still
produces thin libraries and the warnings are gone.
Change-Id: Icef2ba9336196e13cbc43508720874442c3b4460
Reviewed-on: http://gerrit.cloudera.org:8080/9486
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icef2ba9336196e13cbc43508720874442c3b4460
Gerrit-Change-Number: 9486
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] build: fix ar flags to avoid a warning on newer OSes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9486 )
Change subject: build: fix ar flags to avoid a warning on newer OSes
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9486/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9486/1//COMMIT_MSG@18
PS1, Line 18: set(CMAKE_C_ARCHIVE_CREATE "<CMAKE_AR> qc <TARGET> <LINK_FLAGS> <OBJECTS>")
That's the default regardless of platform? Okay then.
--
To view, visit http://gerrit.cloudera.org:8080/9486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef2ba9336196e13cbc43508720874442c3b4460
Gerrit-Change-Number: 9486
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sun, 04 Mar 2018 19:45:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] build: fix ar flags to avoid a warning on newer OSes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9486 )
Change subject: build: fix ar flags to avoid a warning on newer OSes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9486/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9486/1//COMMIT_MSG@18
PS1, Line 18: set(CMAKE_C_ARCHIVE_CREATE "<CMAKE_AR> qc <TARGET> <LINK_FLAGS> <OBJECTS>")
> That's the default regardless of platform? Okay then.
yep
--
To view, visit http://gerrit.cloudera.org:8080/9486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icef2ba9336196e13cbc43508720874442c3b4460
Gerrit-Change-Number: 9486
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 05 Mar 2018 06:35:01 +0000
Gerrit-HasComments: Yes