You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <kl...@apache.org> on 2019/11/11 17:41:07 UTC

Propose adding GEODE-7400 fix to 1.11 release

I propose merging the fix for GEODE-7400 (merged to develop today) to the
1.11 release branch.

My fix for GEODE-7330 (merged to develop in late October) introduced
GEODE-7400 which is the potential for RejectedExecutionException to be
thrown within FederatingManager.

Thanks,
Kirk

commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024
Author: Aaron Lindsey <al...@pivotal.io>
Date:   Mon Nov 11 09:36:24 2019 -0800

    GEODE-7400: Prevent RejectedExecutionException in FederatingManager
(#4270)

    Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the
    FederatingManager class so that it reuses the same ExecutorService
    between restarts. After that change, if we start the manager after
    previously starting and stopping it, we get RejectedExecutionException
    because it tries to invoke a task on the same ExecutorService which has
    been shut down.

    This commit changes the FederatingManager so that it invokes a supplier
    to get a new ExecutorService each time it is started to prevent the
    RejectedExecutionException.

    Co-authored-by: Aaron Lindsey <al...@pivotal.io>
    Co-authored-by: Kirk Lund <kl...@apache.org>

Re: Propose adding GEODE-7400 fix to 1.11 release

Posted by Udo Kohlmeyer <ud...@apache.com>.
+1

On 11/11/19 9:41 AM, Kirk Lund wrote:
> I propose merging the fix for GEODE-7400 (merged to develop today) to the
> 1.11 release branch.
>
> My fix for GEODE-7330 (merged to develop in late October) introduced
> GEODE-7400 which is the potential for RejectedExecutionException to be
> thrown within FederatingManager.
>
> Thanks,
> Kirk
>
> commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024
> Author: Aaron Lindsey <al...@pivotal.io>
> Date:   Mon Nov 11 09:36:24 2019 -0800
>
>      GEODE-7400: Prevent RejectedExecutionException in FederatingManager
> (#4270)
>
>      Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the
>      FederatingManager class so that it reuses the same ExecutorService
>      between restarts. After that change, if we start the manager after
>      previously starting and stopping it, we get RejectedExecutionException
>      because it tries to invoke a task on the same ExecutorService which has
>      been shut down.
>
>      This commit changes the FederatingManager so that it invokes a supplier
>      to get a new ExecutorService each time it is started to prevent the
>      RejectedExecutionException.
>
>      Co-authored-by: Aaron Lindsey <al...@pivotal.io>
>      Co-authored-by: Kirk Lund <kl...@apache.org>
>

Re: Propose adding GEODE-7400 fix to 1.11 release

Posted by Mark Hanson <mh...@pivotal.io>.
FYI, this has been added to the release/1.11.0 branch.

Thanks,
Mark

> On Nov 11, 2019, at 9:42 AM, Jason Huynh <jh...@pivotal.io> wrote:
> 
> +1
> 
> On Mon, Nov 11, 2019 at 9:41 AM Kirk Lund <kl...@apache.org> wrote:
> 
>> I propose merging the fix for GEODE-7400 (merged to develop today) to the
>> 1.11 release branch.
>> 
>> My fix for GEODE-7330 (merged to develop in late October) introduced
>> GEODE-7400 which is the potential for RejectedExecutionException to be
>> thrown within FederatingManager.
>> 
>> Thanks,
>> Kirk
>> 
>> commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024
>> Author: Aaron Lindsey <al...@pivotal.io>
>> Date:   Mon Nov 11 09:36:24 2019 -0800
>> 
>>    GEODE-7400: Prevent RejectedExecutionException in FederatingManager
>> (#4270)
>> 
>>    Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the
>>    FederatingManager class so that it reuses the same ExecutorService
>>    between restarts. After that change, if we start the manager after
>>    previously starting and stopping it, we get RejectedExecutionException
>>    because it tries to invoke a task on the same ExecutorService which has
>>    been shut down.
>> 
>>    This commit changes the FederatingManager so that it invokes a supplier
>>    to get a new ExecutorService each time it is started to prevent the
>>    RejectedExecutionException.
>> 
>>    Co-authored-by: Aaron Lindsey <al...@pivotal.io>
>>    Co-authored-by: Kirk Lund <kl...@apache.org>
>>

Re: Propose adding GEODE-7400 fix to 1.11 release

Posted by Owen Nichols <on...@pivotal.io>.
+1

> On Nov 11, 2019, at 9:42 AM, Jason Huynh <jh...@pivotal.io> wrote:
> 
> +1
> 
> On Mon, Nov 11, 2019 at 9:41 AM Kirk Lund <kl...@apache.org> wrote:
> 
>> I propose merging the fix for GEODE-7400 (merged to develop today) to the
>> 1.11 release branch.
>> 
>> My fix for GEODE-7330 (merged to develop in late October) introduced
>> GEODE-7400 which is the potential for RejectedExecutionException to be
>> thrown within FederatingManager.
>> 
>> Thanks,
>> Kirk
>> 
>> commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024
>> Author: Aaron Lindsey <al...@pivotal.io>
>> Date:   Mon Nov 11 09:36:24 2019 -0800
>> 
>>    GEODE-7400: Prevent RejectedExecutionException in FederatingManager
>> (#4270)
>> 
>>    Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the
>>    FederatingManager class so that it reuses the same ExecutorService
>>    between restarts. After that change, if we start the manager after
>>    previously starting and stopping it, we get RejectedExecutionException
>>    because it tries to invoke a task on the same ExecutorService which has
>>    been shut down.
>> 
>>    This commit changes the FederatingManager so that it invokes a supplier
>>    to get a new ExecutorService each time it is started to prevent the
>>    RejectedExecutionException.
>> 
>>    Co-authored-by: Aaron Lindsey <al...@pivotal.io>
>>    Co-authored-by: Kirk Lund <kl...@apache.org>
>>

Re: Propose adding GEODE-7400 fix to 1.11 release

Posted by Jason Huynh <jh...@pivotal.io>.
+1

On Mon, Nov 11, 2019 at 9:41 AM Kirk Lund <kl...@apache.org> wrote:

> I propose merging the fix for GEODE-7400 (merged to develop today) to the
> 1.11 release branch.
>
> My fix for GEODE-7330 (merged to develop in late October) introduced
> GEODE-7400 which is the potential for RejectedExecutionException to be
> thrown within FederatingManager.
>
> Thanks,
> Kirk
>
> commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024
> Author: Aaron Lindsey <al...@pivotal.io>
> Date:   Mon Nov 11 09:36:24 2019 -0800
>
>     GEODE-7400: Prevent RejectedExecutionException in FederatingManager
> (#4270)
>
>     Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the
>     FederatingManager class so that it reuses the same ExecutorService
>     between restarts. After that change, if we start the manager after
>     previously starting and stopping it, we get RejectedExecutionException
>     because it tries to invoke a task on the same ExecutorService which has
>     been shut down.
>
>     This commit changes the FederatingManager so that it invokes a supplier
>     to get a new ExecutorService each time it is started to prevent the
>     RejectedExecutionException.
>
>     Co-authored-by: Aaron Lindsey <al...@pivotal.io>
>     Co-authored-by: Kirk Lund <kl...@apache.org>
>