You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "r-richmond (via GitHub)" <gi...@apache.org> on 2023/02/20 18:14:47 UTC

[GitHub] [airflow] r-richmond opened a new pull request, #29644: Remove <2.0.0 limit on google-cloud-bigtable

r-richmond opened a new pull request, #29644:
URL: https://github.com/apache/airflow/pull/29644

   related: #27292 
   
   ## What this does
   * Removes <2.0.0 limit on google-cloud-bigtable and corresponding protobuf limit
       * google-cloud-bigtable [no longer requires](https://github.com/googleapis/python-bigtable/blob/main/setup.py#L45) <= 3.2.0 on protobuf
   
   ## Why 
   * python 3.11 support
   * the corresponding protobuf limit restricted multiple other packages from later versions
       * Of interest to me it limited `google-cloud-aiplatform` to `1.13.1`
       * which limited `google-cloud-bigquery` to `>=1.15.0,<3.0.0dev`
   * Only 1 non-significant breaking change in `google-cloud-bigtable` [2.0+](https://github.com/googleapis/python-bigtable/releases/tag/v2.0.0)
       * [Microgenerator changes which removes support for python <= 3.5](https://github.com/googleapis/python-bigtable/pull/203)
       * No other breaking changes in release notes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29644:
URL: https://github.com/apache/airflow/pull/29644#issuecomment-1440292893

   Nice. That one brings us much closer to Python 3.11 support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] r-richmond commented on pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "r-richmond (via GitHub)" <gi...@apache.org>.
r-richmond commented on PR #29644:
URL: https://github.com/apache/airflow/pull/29644#issuecomment-1437945839

   @uranusjr think I got everything. Last test failed due to 2 hour queue timeout.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29644:
URL: https://github.com/apache/airflow/pull/29644


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] uranusjr commented on pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #29644:
URL: https://github.com/apache/airflow/pull/29644#issuecomment-1439520760

   The error is from a bug in our CI setup code. I opened a PR (linked above) to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29644:
URL: https://github.com/apache/airflow/pull/29644#issuecomment-1437952272

   > @uranusjr think I got everything. Last test failed due to 2 hour queue timeout.
   
   Yeah - we had some "blocked" build queue - I unblocked it now. Rebasing to re-run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29644:
URL: https://github.com/apache/airflow/pull/29644#issuecomment-1440293587

   > The error is from a bug in our CI setup code. I opened a PR (linked above) to fix it.
   
   Thanks @uranusjr ! That was a bummer :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] r-richmond commented on pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "r-richmond (via GitHub)" <gi...@apache.org>.
r-richmond commented on PR #29644:
URL: https://github.com/apache/airflow/pull/29644#issuecomment-1439042843

   This hit the same error that my local run of find newer dependencies did. Not sure what to do from here..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] r-richmond commented on pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "r-richmond (via GitHub)" <gi...@apache.org>.
r-richmond commented on PR #29644:
URL: https://github.com/apache/airflow/pull/29644#issuecomment-1438801881

   Latest failure looks like another pipeline issue.
   
   >/home/runner/work/_temp/5e427642-8610-4b5e-8e04-24f61c20032d.sh: line 1:  4290 Killed                  breeze testing tests --run-in-parallel
   [371](https://github.com/apache/airflow/actions/runs/4230102526/jobs/7347288957#step:6:376)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] r-richmond commented on pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "r-richmond (via GitHub)" <gi...@apache.org>.
r-richmond commented on PR #29644:
URL: https://github.com/apache/airflow/pull/29644#issuecomment-1437421451

   >Looks like there are incompatibilities.
   
   Yep, looks like the release notes weren't as truthful this time.. I'll see if I can I fumble my way through this bit later today. (Little difficult on my end since I don't actually use big table just big query but 🤷 )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] uranusjr commented on pull request #29644: Remove <2.0.0 limit on google-cloud-bigtable

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #29644:
URL: https://github.com/apache/airflow/pull/29644#issuecomment-1437417303

   `ImportError: cannot import name 'enums' from 'google.cloud.bigtable_admin_v2'`
   
   Looks like there are incompatibilities.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org