You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/16 22:58:11 UTC

[jira] [Commented] (JENA-1068) Remove DatasetGraphCaching

    [ https://issues.apache.org/jira/browse/JENA-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007421#comment-15007421 ] 

ASF GitHub Bot commented on JENA-1068:
--------------------------------------

GitHub user afs opened a pull request:

    https://github.com/apache/jena/pull/99

    J1068 remove dsg caching

    JENA-1068: Remove use of DatasetGraphCaching.
    
    Removed everywhere then the class put back, deprecated, just in case any external party is using it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afs/jena j1068-remove-dsg-caching

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #99
    
----
commit 44433cf4df109047b6c91e415fc5d70028cff6f4
Author: Andy Seaborne <an...@apache.org>
Date:   2015-11-16T14:55:09Z

    JENA-1068 : Move Helper code into SDB.

commit 7d42969a8cb412a03c4cbeec39a2d25e9f6a26f9
Author: Andy Seaborne <an...@apache.org>
Date:   2015-11-16T17:52:08Z

    JENA-1068: Remove use of DatasetGraphCaching.
    
    Fix tests in AbstractTestUpdateGraphMgt that made bad assumptions
    shown up by this change.
    
    Deprecate DatasetGraphCaching.

commit aeaad43260a3d9cd7fa62d0296e0a7ba07b40d30
Author: Andy Seaborne <an...@apache.org>
Date:   2015-11-16T17:53:33Z

    JENA-1068: DatasetGraphSDB to use DatasetGraphTriplesQuads.
    
    DatasetGraphCaching removed.
    Helper code from DatasetGraphCaching moved locally.

commit 6981dc6de0dd12bbb6b0811f29d3802063419d55
Author: Andy Seaborne <an...@apache.org>
Date:   2015-11-16T17:54:19Z

    JENA-1068: DatasetGraphTDB to use DatasetGraphTriplesQuads.

commit 46b50b7aa35512274d156da6533a9e69eb7e58f5
Author: Andy Seaborne <an...@apache.org>
Date:   2015-11-16T14:55:09Z

    JENA-1068 : Move Helper code into SDB.

commit d6876886952be5bb4306cff1f2724a83048369ed
Author: Andy Seaborne <an...@apache.org>
Date:   2015-11-16T17:52:08Z

    JENA-1068: Remove use of DatasetGraphCaching.
    
    Fix tests in AbstractTestUpdateGraphMgt that made bad assumptions
    shown up by this change.
    
    Deprecate DatasetGraphCaching.

commit e5adf6249f4ffd38af3bb5632af5278abd2ca821
Author: Andy Seaborne <an...@apache.org>
Date:   2015-11-16T17:53:33Z

    JENA-1068: DatasetGraphSDB to use DatasetGraphTriplesQuads.
    
    DatasetGraphCaching removed.
    Helper code from DatasetGraphCaching moved locally.

commit a5794db036946b6225232768625b9b1a747f128e
Author: Andy Seaborne <an...@apache.org>
Date:   2015-11-16T17:54:19Z

    JENA-1068: DatasetGraphTDB to use DatasetGraphTriplesQuads.

commit 3eb846af1625653b66db5918c3138320cc7e6e48
Author: Andy Seaborne <an...@apache.org>
Date:   2015-11-16T21:50:50Z

    Merge branch 'j1068-remove-dsg-caching' of github.com:afs/jena into j1068-remove-dsg-caching

----


> Remove DatasetGraphCaching
> --------------------------
>
>                 Key: JENA-1068
>                 URL: https://issues.apache.org/jira/browse/JENA-1068
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: ARQ, SDB
>    Affects Versions: Jena 3.0.0
>            Reporter: Andy Seaborne
>            Assignee: Andy Seaborne
>            Priority: Minor
>
> This class seems to do nothing much but does add complexity.  There is caching in {{DatasetImpl}} that competes with this caching.  Nowadays, Jena's storage systems are using {{GraphView}} which is very lightweight so caching the creation of graphs is not beneficial and the cache has to be concurrent and transaction safe.
> The internal class {{DatasetGraphCaching.Helper}} is used only in SDB.  {{Helper}} could be moved to into SDB.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)