[jira] Commented: (OFBIZ-2103) Updating Webtool JobList to use PerformFind and FindScreenDecorator

["David E. Jones (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659397#action_12659397 ] 

David E. Jones commented on OFBIZ-2103:
---------------------------------------

Thanks for these contributions Bruno. I like the direction (using the framework tools instead of more manual coding for these screens) and I was going to commit them, but I ran into too many issues to just go for it:

1. there are a lot more changes in the patches than are described in the comments you left; I bring this up as important because as a committer you would need to be detailed in your comments in order to collaborate well with others

2. the WebToolsTabBar patch seems to include the changes from the PerformFindJobList patch, but they are presented as separate patches which makes the contribution unclear and more difficult to review

3. you changed the "main" request-map to require auth, which it should not; it is meant to not require auth to make demo usage easier and provide a starting point; this could be changed, but not without some discussion first; the main point is to be careful about what you change, especially with a large patch like this where accidental damage can be done that others may not catch for a long time (again this goes back to working with others in the community, making sure to understand what already exists before changing anything, and other aspects mentioned in the contributor and committers guides in the admin space on docs.ofbiz.org)

Thanks again for your work on this, and keep going since these are valuable contributions and it's great to see your involvement with the community.




> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: PerformFindJobList.patch, PerformFindJobList.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.