You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2022/09/21 02:42:03 UTC

[pulsar] branch master updated: [feat][build] Print out more info for bin/pulsar version (#17752)

This is an automated email from the ASF dual-hosted git repository.

mmarshall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 2d2a0b85b8f [feat][build] Print out more info for bin/pulsar version (#17752)
2d2a0b85b8f is described below

commit 2d2a0b85b8f02b721e81e012ccf86f5fd5cede1a
Author: Michael Marshall <mm...@apache.org>
AuthorDate: Tue Sep 20 19:41:53 2022 -0700

    [feat][build] Print out more info for bin/pulsar version (#17752)
    
    ### Motivation
    
    The current `bin/pulsar version` script only prints out the version string. When running custom builds of Pulsar, this is sometimes not enough to know which version you have. Since the `PulsarVersion` class already has more information, I propose we print out all of its information in the same format that the broker logs the information.
    
    Here is a sample output for this specific PR:
    
    ```shell
    $ bin/pulsar version
    Current version of pulsar is: 2.11.0-SNAPSHOT
    Git Revision 4414e3d76c27e821e75f30eae853862b04e63200
    Git Branch print-more-version-info
    Built by Michael Marshall <mm...@apache.org> on mmarshall-rmbp16 at 2020-01-22T09:10:15-0600
    ```
    
    ### Modifications
    
    * Add more output to the `bin/pulsar version` command.
    
    ### Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ### Documentation
    
    - [x] `doc-not-needed`
    (Please explain why)
    
    ### Matching PR in forked repository
    
    PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/3
---
 .../src/main/java/org/apache/pulsar/PulsarVersionStarter.java         | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarVersionStarter.java b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarVersionStarter.java
index eea7a7d8bc9..6dab0b4a496 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarVersionStarter.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarVersionStarter.java
@@ -56,5 +56,9 @@ public class PulsarVersionStarter {
             return;
         }
         System.out.println("Current version of pulsar is: " + PulsarVersion.getVersion());
+        System.out.println("Git Revision " + PulsarVersion.getGitSha());
+        System.out.println("Git Branch " + PulsarVersion.getGitBranch());
+        System.out.println("Built by " + PulsarVersion.getBuildUser() + " on " + PulsarVersion.getBuildHost() + " at "
+                + PulsarVersion.getBuildTime());
     }
 }