You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2017/02/07 08:50:33 UTC

[GitHub] flink issue #3281: [FLINK-5727] [table] Unify some API of batch and stream T...

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3281
  
    Hi @KurtYoung,
    
    thanks for the refactoring. Moving `sql()` and `scan()` to `TableEnvironment` makes sense. 
    
    However, I'd like to keep `registerTableSource` at the `BatchTableEnvironment` and `StreamTableEnvironment` because this separation ensures that a `BatchTableSource` is not registered at a `StreamTableEnvironment` and vice versa. 
    
    What do you think?
    
    Best, Fabian


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---