You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2025/10/18 03:38:32 UTC

(spark) branch master updated: [SPARK-53760][GEO][SQL][FOLLOWUP] Fix error message and comment for Spatial types

This is an automated email from the ASF dual-hosted git repository.

wenchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 2c7bc89aadb3 [SPARK-53760][GEO][SQL][FOLLOWUP] Fix error message and comment for Spatial types
2c7bc89aadb3 is described below

commit 2c7bc89aadb3726289b7762670e96afd37f06587
Author: Uros Bojanic <ur...@databricks.com>
AuthorDate: Sat Oct 18 11:38:13 2025 +0800

    [SPARK-53760][GEO][SQL][FOLLOWUP] Fix error message and comment for Spatial types
    
    ### What changes were proposed in this pull request?
    
    - Fix the `ST_INVALID_SRID_VALUE` error message.
    - Fix the `SpatialType` doc comment.
    
    ### Why are the changes needed?
    Followup PR to clean up original issues introduced in: https://github.com/apache/spark/pull/52491.
    
    ### Does this PR introduce _any_ user-facing change?
    Yes, the `ST_INVALID_SRID_VALUE` error message is updated.
    
    ### How was this patch tested?
    Existing tests are sufficient.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No.
    
    Closes #52632 from uros-db/geo-logical-types-FOLLOWUP.
    
    Authored-by: Uros Bojanic <ur...@databricks.com>
    Signed-off-by: Wenchen Fan <we...@databricks.com>
---
 common/utils/src/main/resources/error/error-conditions.json         | 2 +-
 sql/api/src/main/scala/org/apache/spark/sql/types/SpatialType.scala | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/utils/src/main/resources/error/error-conditions.json b/common/utils/src/main/resources/error/error-conditions.json
index 448f0e926a6d..016e764f05cb 100644
--- a/common/utils/src/main/resources/error/error-conditions.json
+++ b/common/utils/src/main/resources/error/error-conditions.json
@@ -5573,7 +5573,7 @@
   },
   "ST_INVALID_SRID_VALUE" : {
     "message" : [
-      "Invalid or unsupported SRID (spatial reference identifier) value: <srid>"
+      "Invalid or unsupported SRID (spatial reference identifier) value: <srid>."
     ],
     "sqlState" : "22023"
   },
diff --git a/sql/api/src/main/scala/org/apache/spark/sql/types/SpatialType.scala b/sql/api/src/main/scala/org/apache/spark/sql/types/SpatialType.scala
index b2818956943c..a61158e36c85 100644
--- a/sql/api/src/main/scala/org/apache/spark/sql/types/SpatialType.scala
+++ b/sql/api/src/main/scala/org/apache/spark/sql/types/SpatialType.scala
@@ -22,7 +22,7 @@ import org.apache.spark.sql.types.AbstractDataType
 trait SpatialType extends AbstractDataType {
 
   /**
-   * Mixed SRID value and the corresponding CRS for geospatial types (Geometry and Geography)
+   * Mixed SRID value and the corresponding CRS for geospatial types (Geometry and Geography).
    * These values represent a geospatial type that can hold different SRID values per row.
    */
   final val MIXED_SRID: Int = -1


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org