[GitHub] [superset] junlincc commented on a change in pull request #13225: fix: missing key on welcome page

[GitBox <gi...@apache.org>]

junlincc commented on a change in pull request #13225:
URL: https://github.com/apache/superset/pull/13225#discussion_r580716381



##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTableRow.tsx
##########
@@ -0,0 +1,111 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import moment from 'moment';
+import ListViewCard from 'src/components/ListViewCard';
+import { CardStyles } from '../utils';
+
+interface ActivityObjects {

Review comment:
       Hey guys sorry i haven't been following the threads. based on the conversation above, my understanding is that 
   1)we are not fixing UI bug, meaning I wouldn't notice it as an end user.  2)there might be a more comprehensive solution to solve this issue. 
   @yardz I prioritize code quality + cleaning up technical debt in Q1-Q2, more than even fixing an actual UI bug. Let's make sure if refractor is necessary, we are not simply putting a bandaid on the code, but solve it from the root, also not get distracted by not prioritized tasks. 
   would you mind addressing @ktmud comment if that's not too much of work, or we can park this PR and move on. 
   
   cc @rusackas 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org