[GitHub] [ozone] sodonnel commented on a diff in pull request #3738: HDDS-7204. EC: Schedule UnderReplicatedProcessor and OverReplicatedProcessor threads in RM instead of StorageContainerManager

[GitBox <gi...@apache.org>]

sodonnel commented on code in PR #3738:
URL: https://github.com/apache/ozone/pull/3738#discussion_r964558329


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -248,6 +261,38 @@ public synchronized void stop() {
     }
   }
 
+  /**
+   * Create Replication Manager sub services such as Over and Under Replication
+   * processors.
+   */
+  private void createSubServices() {

Review Comment:
   I thought we concluded that these sub-services should not be registered with the ServiceManager themselves, but just be threads managed within the replication manager? Perhaps using a "BackgroundThread" base class to manage their run loop etc?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org