You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/06 19:43:14 UTC
[GitHub] [hudi] nsivabalan opened a new pull request, #5773: [HUDI-4192] Fixing sorting of keys fetched from metadata table
nsivabalan opened a new pull request, #5773:
URL: https://github.com/apache/hudi/pull/5773
## What is the purpose of the pull request
- Key prefixes fetched from metadata table in col stats index is not sorted. and hence may result in entries being missed or unnecessary seeks to starting of Hfile. Fixing the same in this patch.
## Brief change log
- Sorting list of key prefixes to be searched with col stats index.
## Verify this pull request
- Fixed one of the test in TestColStatsIndex.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #5773:
URL: https://github.com/apache/hudi/pull/5773#discussion_r890611911
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/storage/TestHoodieHFileReaderWriter.java:
##########
@@ -316,15 +317,20 @@ public void testReaderGetRecordIteratorByKeyPrefixes() throws Exception {
assertEquals(expectedKey50and0s, recordsByPrefix);
// filter for "key1" and "key0" : entries from 'key10 to key19' and 'key00 to key09' should be matched.
- List<GenericRecord> expectedKey1sand0s = expectedKey1s;
- expectedKey1sand0s.addAll(allRecords.stream()
- .filter(entry -> (entry.get("_row_key").toString()).contains("key0"))
- .collect(Collectors.toList()));
+ List<GenericRecord> expectedKey1sand0s = allRecords.stream()
+ .filter(entry -> (entry.get("_row_key").toString()).contains("key1") || (entry.get("_row_key").toString()).contains("key0"))
+ .collect(Collectors.toList());
iterator =
hfileReader.getRecordsByKeyPrefixIterator(Arrays.asList("key1", "key0"), avroSchema);
recordsByPrefix =
StreamSupport.stream(Spliterators.spliteratorUnknownSize(iterator, Spliterator.ORDERED), false)
.collect(Collectors.toList());
+ Collections.sort(recordsByPrefix, new Comparator<GenericRecord>() {
Review Comment:
Why is this needed?
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -192,8 +197,12 @@ public HoodieData<HoodieRecord<HoodieMetadataPayload>> getRecordsByKeyPrefixes(L
}
@Override
- public List<Pair<String, Option<HoodieRecord<HoodieMetadataPayload>>>> getRecordsByKeys(List<String> keys,
+ public List<Pair<String, Option<HoodieRecord<HoodieMetadataPayload>>>> getRecordsByKeys(List<String> keysUnsorted,
String partitionName) {
+ // Sort the columns so that keys are looked up in order
+ List<String> keys = new ArrayList<>();
Review Comment:
Same as above
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -142,8 +142,13 @@ protected Option<HoodieRecord<HoodieMetadataPayload>> getRecordByKey(String key,
}
@Override
- public HoodieData<HoodieRecord<HoodieMetadataPayload>> getRecordsByKeyPrefixes(List<String> keyPrefixes,
+ public HoodieData<HoodieRecord<HoodieMetadataPayload>> getRecordsByKeyPrefixes(List<String> keyPrefixesUnsorted,
String partitionName) {
+ // Sort the columns so that keys are looked up in order
+ List<String> keyPrefixes = new ArrayList<>();
Review Comment:
In general it's better to use `new ArrayList(col)` ctor as this would avoid subsequent re-allocation
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -142,8 +142,13 @@ protected Option<HoodieRecord<HoodieMetadataPayload>> getRecordByKey(String key,
}
@Override
- public HoodieData<HoodieRecord<HoodieMetadataPayload>> getRecordsByKeyPrefixes(List<String> keyPrefixes,
+ public HoodieData<HoodieRecord<HoodieMetadataPayload>> getRecordsByKeyPrefixes(List<String> keyPrefixesUnsorted,
Review Comment:
Name is misleading -- prefixes might be sorted. I don't think we need to change the name. we just need to make sure we're sorting and that's it
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestColumnStatsIndex.scala:
##########
@@ -250,7 +250,7 @@ class TestColumnStatsIndex extends HoodieClientTestBase with ColumnStatsIndexSup
{
// We have to include "c1", since we sort the expected outputs by this column
- val requestedColumns = Seq("c1", "c4")
+ val requestedColumns = Seq("c2", "c1", "c4")
Review Comment:
nit: Flipping the order we could have avoided need to change the fixture
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileReader.java:
##########
@@ -259,11 +259,8 @@ private static Iterator<GenericRecord> getRecordByKeyPrefixIteratorInternal(HFil
return Collections.emptyIterator();
}
} else if (val == -1) {
- // If scanner is aleady on the top of hfile. avoid trigger seekTo again.
- Option<Cell> headerCell = Option.fromJavaOptional(scanner.getReader().getFirstKey());
- if (headerCell.isPresent() && !headerCell.get().equals(scanner.getCell())) {
- scanner.seekTo();
- }
+ // seek to beginning. anyways, its key prefix search.
Review Comment:
Let's elaborate the comment to make sure someone reading it w/o context is able to understand it:
Whenever `val == -1` HFile reader will place the pointer right before the first record. We have to advance it to the first record of the file to validate whether it matches our search criteria
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -192,8 +197,12 @@ public HoodieData<HoodieRecord<HoodieMetadataPayload>> getRecordsByKeyPrefixes(L
}
@Override
- public List<Pair<String, Option<HoodieRecord<HoodieMetadataPayload>>>> getRecordsByKeys(List<String> keys,
+ public List<Pair<String, Option<HoodieRecord<HoodieMetadataPayload>>>> getRecordsByKeys(List<String> keysUnsorted,
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4192] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1147842194
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 597733efd5d2c1b25b5e0b3f6a628752eff9e52c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4192] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1147845696
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 597733efd5d2c1b25b5e0b3f6a628752eff9e52c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1148163515
LGTM
@nsivabalan maybe in a follow-up let's add a comment to the corresponding java-docs for getKeyPrefixIterator and getKeysIterator that keys are expected to be sorted (by the caller) for efficiency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1148082530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
}, {
"hash" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114",
"triggerID" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9117",
"triggerID" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"triggerType" : "PUSH"
}, {
"hash" : "77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9119",
"triggerID" : "77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
* 752a5403aae52b361919cbf98639972e0fbeb5b6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114)
* de800857471161785bebeb96adcbdcd4c6b09a96 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9117)
* 77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9119)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #5773:
URL: https://github.com/apache/hudi/pull/5773#discussion_r890736607
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/storage/TestHoodieHFileReaderWriter.java:
##########
@@ -316,15 +317,20 @@ public void testReaderGetRecordIteratorByKeyPrefixes() throws Exception {
assertEquals(expectedKey50and0s, recordsByPrefix);
// filter for "key1" and "key0" : entries from 'key10 to key19' and 'key00 to key09' should be matched.
- List<GenericRecord> expectedKey1sand0s = expectedKey1s;
- expectedKey1sand0s.addAll(allRecords.stream()
- .filter(entry -> (entry.get("_row_key").toString()).contains("key0"))
- .collect(Collectors.toList()));
+ List<GenericRecord> expectedKey1sand0s = allRecords.stream()
+ .filter(entry -> (entry.get("_row_key").toString()).contains("key1") || (entry.get("_row_key").toString()).contains("key0"))
+ .collect(Collectors.toList());
iterator =
hfileReader.getRecordsByKeyPrefixIterator(Arrays.asList("key1", "key0"), avroSchema);
recordsByPrefix =
StreamSupport.stream(Spliterators.spliteratorUnknownSize(iterator, Spliterator.ORDERED), false)
.collect(Collectors.toList());
+ Collections.sort(recordsByPrefix, new Comparator<GenericRecord>() {
Review Comment:
We should revert this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #5773: [HUDI-4192] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1147967892
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #5773:
URL: https://github.com/apache/hudi/pull/5773#discussion_r890630049
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/storage/TestHoodieHFileReaderWriter.java:
##########
@@ -316,15 +317,20 @@ public void testReaderGetRecordIteratorByKeyPrefixes() throws Exception {
assertEquals(expectedKey50and0s, recordsByPrefix);
// filter for "key1" and "key0" : entries from 'key10 to key19' and 'key00 to key09' should be matched.
- List<GenericRecord> expectedKey1sand0s = expectedKey1s;
- expectedKey1sand0s.addAll(allRecords.stream()
- .filter(entry -> (entry.get("_row_key").toString()).contains("key0"))
- .collect(Collectors.toList()));
+ List<GenericRecord> expectedKey1sand0s = allRecords.stream()
+ .filter(entry -> (entry.get("_row_key").toString()).contains("key1") || (entry.get("_row_key").toString()).contains("key0"))
+ .collect(Collectors.toList());
iterator =
hfileReader.getRecordsByKeyPrefixIterator(Arrays.asList("key1", "key0"), avroSchema);
recordsByPrefix =
StreamSupport.stream(Spliterators.spliteratorUnknownSize(iterator, Spliterator.ORDERED), false)
.collect(Collectors.toList());
+ Collections.sort(recordsByPrefix, new Comparator<GenericRecord>() {
Review Comment:
we do not sort the return values from getRecordsByKeyPrefixIterator. but the expected ones are sorted. and hence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4192] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1147975892
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
}, {
"hash" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114",
"triggerID" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
* Unknown: [CANCELED](TBD)
* 752a5403aae52b361919cbf98639972e0fbeb5b6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1148043369
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
}, {
"hash" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114",
"triggerID" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
* 752a5403aae52b361919cbf98639972e0fbeb5b6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114)
* de800857471161785bebeb96adcbdcd4c6b09a96 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4192] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1147960534
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 597733efd5d2c1b25b5e0b3f6a628752eff9e52c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1148048397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
}, {
"hash" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114",
"triggerID" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9117",
"triggerID" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
* 752a5403aae52b361919cbf98639972e0fbeb5b6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114)
* de800857471161785bebeb96adcbdcd4c6b09a96 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9117)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4192] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1147969811
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #5773:
URL: https://github.com/apache/hudi/pull/5773#discussion_r890640414
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/storage/TestHoodieHFileReaderWriter.java:
##########
@@ -316,15 +317,20 @@ public void testReaderGetRecordIteratorByKeyPrefixes() throws Exception {
assertEquals(expectedKey50and0s, recordsByPrefix);
// filter for "key1" and "key0" : entries from 'key10 to key19' and 'key00 to key09' should be matched.
- List<GenericRecord> expectedKey1sand0s = expectedKey1s;
- expectedKey1sand0s.addAll(allRecords.stream()
- .filter(entry -> (entry.get("_row_key").toString()).contains("key0"))
- .collect(Collectors.toList()));
+ List<GenericRecord> expectedKey1sand0s = allRecords.stream()
+ .filter(entry -> (entry.get("_row_key").toString()).contains("key1") || (entry.get("_row_key").toString()).contains("key0"))
+ .collect(Collectors.toList());
iterator =
hfileReader.getRecordsByKeyPrefixIterator(Arrays.asList("key1", "key0"), avroSchema);
recordsByPrefix =
StreamSupport.stream(Spliterators.spliteratorUnknownSize(iterator, Spliterator.ORDERED), false)
.collect(Collectors.toList());
+ Collections.sort(recordsByPrefix, new Comparator<GenericRecord>() {
Review Comment:
But they should be sorted since they are sorted in HFile and prefixes are sorted internally, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1148133339
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
}, {
"hash" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114",
"triggerID" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9117",
"triggerID" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"triggerType" : "PUSH"
}, {
"hash" : "77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9119",
"triggerID" : "77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
* 77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9119)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1148041366
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
}, {
"hash" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114",
"triggerID" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
* 752a5403aae52b361919cbf98639972e0fbeb5b6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
nsivabalan merged PR #5773:
URL: https://github.com/apache/hudi/pull/5773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4192] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1147973103
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
}, {
"hash" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
* Unknown: [CANCELED](TBD)
* 752a5403aae52b361919cbf98639972e0fbeb5b6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1148076978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
}, {
"hash" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114",
"triggerID" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9117",
"triggerID" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"triggerType" : "PUSH"
}, {
"hash" : "77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
* 752a5403aae52b361919cbf98639972e0fbeb5b6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114)
* de800857471161785bebeb96adcbdcd4c6b09a96 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9117)
* 77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5773: [HUDI-4200] Fixing sorting of keys fetched from metadata table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5773:
URL: https://github.com/apache/hudi/pull/5773#issuecomment-1148103783
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9112",
"triggerID" : "597733efd5d2c1b25b5e0b3f6a628752eff9e52c",
"triggerType" : "PUSH"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "f85071f92ef89f220112a36914572a10a940563d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f85071f92ef89f220112a36914572a10a940563d",
"triggerType" : "PUSH"
}, {
"hash" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9114",
"triggerID" : "752a5403aae52b361919cbf98639972e0fbeb5b6",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1147967892",
"triggerType" : "MANUAL"
}, {
"hash" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9117",
"triggerID" : "de800857471161785bebeb96adcbdcd4c6b09a96",
"triggerType" : "PUSH"
}, {
"hash" : "77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9119",
"triggerID" : "77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f85071f92ef89f220112a36914572a10a940563d UNKNOWN
* de800857471161785bebeb96adcbdcd4c6b09a96 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9117)
* 77be04f93ecee8d2b8fbd46aaf4ec50b2c990bae Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9119)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org