You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2022/06/03 05:02:02 UTC
[superset] branch revert-20147-limiting-modal-height created (now 387e2f5789)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a change to branch revert-20147-limiting-modal-height
in repository https://gitbox.apache.org/repos/asf/superset.git
at 387e2f5789 Revert "fix(cosmetic): Limiting modal height (#20147)"
This branch includes the following new commits:
new 387e2f5789 Revert "fix(cosmetic): Limiting modal height (#20147)"
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: Revert "fix(cosmetic): Limiting modal height (#20147)"
Posted by ru...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch revert-20147-limiting-modal-height
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 387e2f57895a47b632cf1b8b5ca7df46a05e5b22
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Thu Jun 2 23:01:54 2022 -0600
Revert "fix(cosmetic): Limiting modal height (#20147)"
This reverts commit c8fe518a7b55fe48545228dca6cf4f7c400f04e6.
---
superset-frontend/src/components/Modal/Modal.tsx | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/superset-frontend/src/components/Modal/Modal.tsx b/superset-frontend/src/components/Modal/Modal.tsx
index c6d5b3ee0a..8ef38a7e8d 100644
--- a/superset-frontend/src/components/Modal/Modal.tsx
+++ b/superset-frontend/src/components/Modal/Modal.tsx
@@ -89,20 +89,9 @@ export const StyledModal = styled(BaseModal)<StyledModalProps>`
max-width: ${maxWidth ?? '900px'};
padding-left: ${theme.gridUnit * 3}px;
padding-right: ${theme.gridUnit * 3}px;
- padding-bottom: 0;
- top: 0;
`}
- .ant-modal-content {
- display: flex;
- flex-direction: column;
- max-height: ${({ theme }) => `calc(100vh - ${theme.gridUnit * 8}px)`};
- margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;
- margin-top: ${({ theme }) => theme.gridUnit * 4}px;
- }
-
.ant-modal-header {
- flex: 0 0 auto;
background-color: ${({ theme }) => theme.colors.grayscale.light4};
border-radius: ${({ theme }) => theme.borderRadius}px
${({ theme }) => theme.borderRadius}px 0 0;
@@ -130,13 +119,11 @@ export const StyledModal = styled(BaseModal)<StyledModalProps>`
}
.ant-modal-body {
- flex: 0 1 auto;
padding: ${({ theme }) => theme.gridUnit * 4}px;
overflow: auto;
${({ resizable, height }) => !resizable && height && `height: ${height};`}
}
.ant-modal-footer {
- flex: 0 0 1;
border-top: ${({ theme }) => theme.gridUnit / 4}px solid
${({ theme }) => theme.colors.grayscale.light2};
padding: ${({ theme }) => theme.gridUnit * 4}px;