You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rs...@apache.org on 2016/07/03 15:09:24 UTC
svn commit: r1751156 - /subversion/branches/1.9.x/STATUS
Author: rschupp
Date: Sun Jul 3 15:09:24 2016
New Revision: 1751156
URL: http://svn.apache.org/viewvc?rev=1751156&view=rev
Log:
- vote for r1683266
- nominate r1683266, r1683267
Modified:
subversion/branches/1.9.x/STATUS
Modified: subversion/branches/1.9.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.9.x/STATUS?rev=1751156&r1=1751155&r2=1751156&view=diff
==============================================================================
--- subversion/branches/1.9.x/STATUS (original)
+++ subversion/branches/1.9.x/STATUS Sun Jul 3 15:09:24 2016
@@ -136,6 +136,20 @@ Candidate changes:
Votes:
+1: stsp
+ * r1683266, r1683267
+ Avoid possible stack corruption in swig-perl (see also r1683266)
+ Justification:
+ These changes go deeper than r1683266 where the possibility that the
+ Perl stack is re-allocated "from under us" is in plain sight.
+ They bracket calls to functions svn_swig_pl_make_pool and
+ svn_swig_pl_callback_thunk that call back into Perl which
+ meaning that somewhere even further down the call chain
+ Perl may re-allocate its stack. Note that calling PUTBACK or SPAGAIN
+ is never wrong, it might just be not necessary (if we can prove that
+ the cached stack pointer (SP) can't change in between).
+ Votes:
+ +1: rschupp
+
Veto-blocked changes:
=====================
@@ -150,4 +164,5 @@ Approved changes:
http://www.mail-archive.com/git@vger.kernel.org/msg97227.html
Votes:
+0: rhuijben
- +1: stsp
\ No newline at end of file
+ +1: stsp
+ +1: rschupp